Bug 95390
| Summary: | rebaselining doesn't really work w/ multiple expectations files | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Dirk Pranke <dpranke> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | abarth, jchaffraix, rniwa |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Dirk Pranke
If, for example, you mark a test for REBASELINE in platform/chromium/TestExpectations, and there is an overriding line in the skia_test_expectations.txt file, webkit-patch rebaseline-expectations will not see the line with the REBASELINE.
After r127057, at least we'll log a warning that we didn't find a REBASELINE, but we should either be smarter about this (e.g., log a warning that tests are shadowing others) or stop using rebaseline-expectations altogether ;).
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Dirk Pranke
changing subject from
"expectation overrides can cause REBASELINE modifiers to be missed"
to
"rebaselining doesn't really work w/ multiple expectations files"
Dirk Pranke
I don't expect to work on this in the webkit.org repo in the foreseeable future, so I'm clearing the 'assigned_to' field in case someone cares to take a look.