Bug 95371

Summary: [chromium] Make link highlighter use same node selection criteria as Chromium for Android.
Product: WebKit Reporter: W. James MacLean <wjmaclean>
Component: New BugsAssignee: W. James MacLean <wjmaclean>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, jamesr, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

W. James MacLean
Reported 2012-08-29 13:27:05 PDT
[chromium] Make link highlighter use same node selection criteria as Chromium for Android.
Attachments
Patch (29.62 KB, patch)
2012-08-29 13:29 PDT, W. James MacLean 		no flags
DetailsFormatted DiffDiff
Patch (30.74 KB, patch)
2012-08-30 07:41 PDT, W. James MacLean 		no flags
DetailsFormatted DiffDiff
Patch for landing (30.74 KB, patch)
2012-08-31 12:20 PDT, W. James MacLean 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
W. James MacLean
Comment 1 2012-08-29 13:29:14 PDT
Created attachment 161298 [details] Patch This patch brings the choice of which node to highlight into alignment with Chromium for Android, for sake of consistency.
WebKit Review Bot
Comment 2 2012-08-29 23:17:38 PDT
Comment on attachment 161298 [details] Patch Attachment 161298 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13682558 New failing tests: LinkHighlightTest.verifyWebViewImplIntegration
W. James MacLean
Comment 3 2012-08-30 07:41:17 PDT
Created attachment 161466 [details] Patch Ooops, the .html resource file for the unit test was violating the auto z-index constraint ... fixed.
W. James MacLean
Comment 4 2012-08-31 12:20:07 PDT
Created attachment 161750 [details] Patch for landing
WebKit Review Bot
Comment 5 2012-08-31 17:32:49 PDT
Comment on attachment 161750 [details] Patch for landing Clearing flags on attachment: 161750 Committed r127342: <http://trac.webkit.org/changeset/127342>
WebKit Review Bot
Comment 6 2012-08-31 17:32:52 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.