Bug 95353

Summary:

'\r's in test expectations files confused chromium-android layout test driver

Product:

WebKit

Reporter:

Xianzhu Wang <wangxianzhu>

Component:

Tools / Tests

Assignee:

Xianzhu Wang <wangxianzhu>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, ggaren, sam

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

93627

Attachments:

Description	Flags
Patch	none
=Fixed an unexpected change. Will land manually	none

Xianzhu Wang

Reported 2012-08-29 09:37:37 PDT

The following layout tests will output '\r's in the test results, which confuses chromium-android layout test driver because the new lines will be formalized when reading through 'adb shell': fast/dom/Window/window-property-clearing.html LayoutTests/fast/dom/simultaneouslyRegsiteredTimerFireOrder.html

Attachments
Patch (13.57 KB, patch) 2012-08-29 09:40 PDT, Xianzhu Wang	no flags	Details Formatted Diff Diff
=Fixed an unexpected change. Will land manually (13.43 KB, patch) 2012-08-29 10:17 PDT, Xianzhu Wang	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Xianzhu Wang

Comment 1 2012-08-29 09:40:20 PDT

Created attachment 161249 [details] Patch

Xianzhu Wang

Comment 2 2012-08-29 09:47:28 PDT

Seems that this kind of patch can't be applied in normal way. I can also leave the expectation files unchanged, because at least on chromium-linux and chromium-android the line separators are ignored when comparing actual results to expectations, but I don't know how other platforms deal with line separators.

Adam Barth

Comment 3 2012-08-29 09:55:22 PDT

We can also land it manually.

Adam Barth

Comment 4 2012-08-29 09:55:30 PDT

Let me know what you prefer.

Xianzhu Wang

Comment 5 2012-08-29 09:56:43 PDT

(In reply to comment #4) > Let me know what you prefer. I'd like to try CQ first. If it can't make it, I'll land it manually.

Adam Barth

Comment 6 2012-08-29 09:58:08 PDT

Comment on attachment 161249 [details] Patch I doubt the cq will do any better than the style bot.

Xianzhu Wang

Comment 7 2012-08-29 10:02:21 PDT

(In reply to comment #6) > (From update of attachment 161249 [details]) > I doubt the cq will do any better than the style bot. Agreed. As just found an unexpected change in the uploaded patch, I'll fix that try to submit it manually. Will be careful not to make the mistake as before :)

Xianzhu Wang

Comment 8 2012-08-29 10:17:56 PDT

Created attachment 161260 [details] =Fixed an unexpected change. Will land manually

Xianzhu Wang

Comment 9 2012-08-29 10:18:20 PDT

Committed r127012: <http://trac.webkit.org/changeset/127012>

Note You need to log in before you can comment on or make changes to this bug.