Bug 95338

Summary: [BlackBerry] Eliminate build warnings
Product: WebKit Reporter: Charles Wei <charles.wei>
Component: WebCore JavaScriptAssignee: Charles Wei <charles.wei>
Status: RESOLVED FIXED    
Severity: Normal CC: fpizlo, haraken, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Charles Wei
Reported 2012-08-29 05:53:59 PDT
Comparison between signed and unsigned integers generates warnings. Need to cast them to the same type to eliminate the warnings.
Attachments
Patch (3.42 KB, patch)
2012-08-29 05:58 PDT, Charles Wei 		no flags
DetailsFormatted DiffDiff
Patch (2.53 KB, patch)
2012-08-30 00:47 PDT, Charles Wei 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Charles Wei
Comment 1 2012-08-29 05:58:02 PDT
Created attachment 161205 [details] Patch
Kentaro Hara
Comment 2 2012-08-29 07:08:06 PDT
Comment on attachment 161205 [details] Patch OK
Build Bot
Comment 3 2012-08-29 07:51:35 PDT
Comment on attachment 161205 [details] Patch Attachment 161205 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/13682224
Kentaro Hara
Comment 4 2012-08-29 22:50:24 PDT
Comment on attachment 161205 [details] Patch r-ing due to pizlo's comment here (https://bugs.webkit.org/show_bug.cgi?id=95418#c4). Sorry for the wrong review.
Filip Pizlo
Comment 5 2012-08-29 22:53:12 PDT
(In reply to comment #4) > (From update of attachment 161205 [details]) > r-ing due to pizlo's comment here (https://bugs.webkit.org/show_bug.cgi?id=95418#c4). Sorry for the wrong review. No worries! Signed comparisons in C++ are so annoying! ;-)
Charles Wei
Comment 6 2012-08-30 00:47:05 PDT
Created attachment 161415 [details] Patch
WebKit Review Bot
Comment 7 2012-08-30 05:36:48 PDT
Comment on attachment 161415 [details] Patch Clearing flags on attachment: 161415 Committed r127128: <http://trac.webkit.org/changeset/127128>
WebKit Review Bot
Comment 8 2012-08-30 05:36:51 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.