Bug 95318

Summary: [WK2] Use ASCIILiteral hotness for DEFINE_STATIC_LOCAL string
Product: WebKit Reporter: Gyuyoung Kim <gyuyoung.kim>
Component: WebKit2Assignee: Gyuyoung Kim <gyuyoung.kim>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Gyuyoung Kim
Reported 2012-08-29 02:46:13 PDT
As recommended by http://trac.webkit.org/wiki/EfficientStrings, WebKit2 needs to change the string of DEFINE_STATIC_LOCAL.
Attachments
Patch (13.54 KB, patch)
2012-08-29 02:47 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Patch (12.47 KB, patch)
2012-08-29 03:26 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Patch (11.39 KB, patch)
2012-08-29 16:36 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Gyuyoung Kim
Comment 1 2012-08-29 02:47:34 PDT
Created attachment 161164 [details] Patch
Build Bot
Comment 2 2012-08-29 03:14:43 PDT
Comment on attachment 161164 [details] Patch Attachment 161164 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/13688141
Gyuyoung Kim
Comment 3 2012-08-29 03:26:13 PDT
Created attachment 161171 [details] Patch
Build Bot
Comment 4 2012-08-29 04:49:20 PDT
Comment on attachment 161171 [details] Patch Attachment 161171 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/13690164
Gyuyoung Kim
Comment 5 2012-08-29 16:36:16 PDT
Created attachment 161354 [details] Patch
Benjamin Poulain
Comment 6 2012-08-29 18:55:38 PDT
Comment on attachment 161354 [details] Patch Great!
Gyuyoung Kim
Comment 7 2012-08-29 18:57:17 PDT
Comment on attachment 161354 [details] Patch I'm sure this will not influence on cr port.
WebKit Review Bot
Comment 8 2012-08-29 21:52:59 PDT
Comment on attachment 161354 [details] Patch Clearing flags on attachment: 161354 Committed r127098: <http://trac.webkit.org/changeset/127098>
WebKit Review Bot
Comment 9 2012-08-29 21:53:03 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.