Bug 95318 - [WK2] Use ASCIILiteral hotness for DEFINE_STATIC_LOCAL string
Summary: [WK2] Use ASCIILiteral hotness for DEFINE_STATIC_LOCAL string
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-29 02:46 PDT by Gyuyoung Kim
Modified: 2012-08-29 21:53 PDT (History)
2 users (show)

See Also:


Attachments
Patch (13.54 KB, patch)
2012-08-29 02:47 PDT, Gyuyoung Kim
no flags Details | Formatted Diff | Diff
Patch (12.47 KB, patch)
2012-08-29 03:26 PDT, Gyuyoung Kim
no flags Details | Formatted Diff | Diff
Patch (11.39 KB, patch)
2012-08-29 16:36 PDT, Gyuyoung Kim
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2012-08-29 02:46:13 PDT
As recommended by http://trac.webkit.org/wiki/EfficientStrings, WebKit2 needs to change the string of DEFINE_STATIC_LOCAL.
Comment 1 Gyuyoung Kim 2012-08-29 02:47:34 PDT
Created attachment 161164 [details]
Patch
Comment 2 Build Bot 2012-08-29 03:14:43 PDT
Comment on attachment 161164 [details]
Patch

Attachment 161164 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/13688141
Comment 3 Gyuyoung Kim 2012-08-29 03:26:13 PDT
Created attachment 161171 [details]
Patch
Comment 4 Build Bot 2012-08-29 04:49:20 PDT
Comment on attachment 161171 [details]
Patch

Attachment 161171 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/13690164
Comment 5 Gyuyoung Kim 2012-08-29 16:36:16 PDT
Created attachment 161354 [details]
Patch
Comment 6 Benjamin Poulain 2012-08-29 18:55:38 PDT
Comment on attachment 161354 [details]
Patch

Great!
Comment 7 Gyuyoung Kim 2012-08-29 18:57:17 PDT
Comment on attachment 161354 [details]
Patch

I'm sure this will not influence on cr port.
Comment 8 WebKit Review Bot 2012-08-29 21:52:59 PDT
Comment on attachment 161354 [details]
Patch

Clearing flags on attachment: 161354

Committed r127098: <http://trac.webkit.org/changeset/127098>
Comment 9 WebKit Review Bot 2012-08-29 21:53:03 PDT
All reviewed patches have been landed.  Closing bug.