Bug 95315

Summary: Web Inspector: unsafe static_cast in RetainedDOMInfo::IsEquivalent
Product: WebKit Reporter: Yury Semikhatsky <yurys>
Component: Web Inspector (Deprecated)Assignee: Yury Semikhatsky <yurys>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, alph, apavlov, bweinstein, haraken, japhet, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Yury Semikhatsky
Reported 2012-08-29 02:08:59 PDT
Before casting v8::RetainedObjectInfo to WebCore::RetainedObjectInfo we should check if it is an instance of WebCore::RetainedObjectInfo as it may happen to be an instance of v8::internal::NativeGroupRetainedObjectInfo. This check can be accomplished by comparing labels of the two objects as the labels should be unique for retained groups.
Attachments
Patch (1.71 KB, patch)
2012-08-29 02:14 PDT, Yury Semikhatsky 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yury Semikhatsky
Comment 1 2012-08-29 02:14:28 PDT
Created attachment 161163 [details] Patch
Ilya Tikhonovsky
Comment 2 2012-08-29 02:15:53 PDT
Comment on attachment 161163 [details] Patch lgtm
WebKit Review Bot
Comment 3 2012-08-29 04:52:56 PDT
Comment on attachment 161163 [details] Patch Clearing flags on attachment: 161163 Committed r126989: <http://trac.webkit.org/changeset/126989>
WebKit Review Bot
Comment 4 2012-08-29 04:52:59 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.