Bug 95285

Summary: [Tests] Add test case for right-to-left rendering of multiple fields time input UI
Product: WebKit Reporter: yosin
Component: Tools / TestsAssignee: yosin
Status: RESOLVED FIXED    
Severity: Normal CC: tkent
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 95168    
Attachments:
Description Flags
Patch 1
none
Patch 2 none

yosin
Reported 2012-08-28 21:56:05 PDT
We should have a test case of RTL appearance of multiple fields time input UI.
Attachments
Patch 1 (39.79 KB, patch)
2012-08-29 18:55 PDT, yosin 		no flags
DetailsFormatted DiffDiff
Patch 2 (39.86 KB, patch)
2012-08-29 19:18 PDT, yosin 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
yosin
Comment 1 2012-08-29 18:55:43 PDT
Created attachment 161386 [details] Patch 1
yosin
Comment 2 2012-08-29 18:56:37 PDT
Comment on attachment 161386 [details] Patch 1 Could you review this patch? Thanks in advance.
Kent Tamura
Comment 3 2012-08-29 19:11:00 PDT
Comment on attachment 161386 [details] Patch 1 View in context: https://bugs.webkit.org/attachment.cgi?id=161386&action=review > LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic.html:10 > + <li>RTL <input type="time" step="1" value="12:34:56"></li> This is not RTL.
yosin
Comment 4 2012-08-29 19:18:34 PDT
Created attachment 161389 [details] Patch 2
yosin
Comment 5 2012-08-29 19:19:55 PDT
Comment on attachment 161389 [details] Patch 2 Could you review this patch? Thanks in advance. = Changes since the last review = * Add 'dir="rtl"' to test case. * Update expectation PNG and TXT
Kent Tamura
Comment 6 2012-08-29 20:05:18 PDT
Comment on attachment 161389 [details] Patch 2 ok
yosin
Comment 7 2012-08-29 20:22:14 PDT
Comment on attachment 161389 [details] Patch 2 Clearing flags on attachment: 161389 Committed r127089: <http://trac.webkit.org/changeset/127089>
yosin
Comment 8 2012-08-29 20:22:18 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.