Bug 95285

Summary:

[Tests] Add test case for right-to-left rendering of multiple fields time input UI

Product:

WebKit

Reporter:

yosin

Component:

Tools / Tests

Assignee:

yosin

Status:

RESOLVED FIXED

Severity:

Normal

CC:

tkent

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

95168

Attachments:

Description	Flags
Patch 1	none
Patch 2	none

Description yosin 2012-08-28 21:56:05 PDT

We should have a test case of RTL appearance of multiple fields time input UI.

Comment 1 yosin 2012-08-29 18:55:43 PDT

Created attachment 161386 [details]
Patch 1

Comment 2 yosin 2012-08-29 18:56:37 PDT

Comment on attachment 161386 [details]
Patch 1

Could you review this patch?
Thanks in advance.

Comment 3 Kent Tamura 2012-08-29 19:11:00 PDT

Comment on attachment 161386 [details]
Patch 1

View in context: https://bugs.webkit.org/attachment.cgi?id=161386&action=review

> LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic.html:10
> +    <li>RTL <input type="time" step="1" value="12:34:56"></li>

This is not RTL.

Comment 4 yosin 2012-08-29 19:18:34 PDT

Created attachment 161389 [details]
Patch 2

Comment 5 yosin 2012-08-29 19:19:55 PDT

Comment on attachment 161389 [details]
Patch 2

Could you review this patch?
Thanks in advance.

= Changes since the last review =
* Add 'dir="rtl"' to test case.
* Update expectation PNG and TXT

Comment 6 Kent Tamura 2012-08-29 20:05:18 PDT

Comment on attachment 161389 [details]
Patch 2

ok

Comment 7 yosin 2012-08-29 20:22:14 PDT

Comment on attachment 161389 [details]
Patch 2

Clearing flags on attachment: 161389

Committed r127089: <http://trac.webkit.org/changeset/127089>

Comment 8 yosin 2012-08-29 20:22:18 PDT

All reviewed patches have been landed.  Closing bug.