Bug 95280

Summary: [Forms] Rename DateTimeFieldElement::FieldEventHandler to FieldOwner
Product: WebKit Reporter: yosin
Component: FormsAssignee: yosin
Status: RESOLVED FIXED    
Severity: Normal CC: haraken, morrita, tkent
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 95168    
Attachments:
Description Flags
Patch 1 none

yosin
Reported 2012-08-28 21:07:33 PDT
For changing Shift+Tab behavior of multiple field time input UI, DateTimeFieldElement needs to ask field owner for moving focus around field, e.g. focusOnNextFIeld(), and focusOnPreviousField(). These new functions aren't fit for in FieldEventHandler. To make class name matched to its functionality, we would like to rename FieldEventHandler to FieldOwner. See https://bugs.webkit.org/attachment.cgi?id=161128&action=prettypatch for usage of DateTimeFieldElement::FieldOwner class.
Attachments
Patch 1 (20.34 KB, patch)
2012-08-28 21:20 PDT, yosin 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
yosin
Comment 1 2012-08-28 21:20:34 PDT
Created attachment 161130 [details] Patch 1
yosin
Comment 2 2012-08-28 21:21:14 PDT
Comment on attachment 161130 [details] Patch 1 Could you review this patch? Thanks in advance.
Kent Tamura
Comment 3 2012-08-29 17:57:50 PDT
(In reply to comment #2) > (From update of attachment 161130 [details]) > Could you review this patch? Then, please set r? flag.
yosin
Comment 4 2012-08-29 18:39:26 PDT
Comment on attachment 161130 [details] Patch 1 Could you review this patch? Thanks in advance. P.S. I forgot to set "r?".... orz
Kent Tamura
Comment 5 2012-08-29 19:08:23 PDT
Comment on attachment 161130 [details] Patch 1 ok
yosin
Comment 6 2012-08-29 19:24:14 PDT
Comment on attachment 161130 [details] Patch 1 Clearing flags on attachment: 161130 Committed r127085: <http://trac.webkit.org/changeset/127085>
yosin
Comment 7 2012-08-29 19:24:17 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.