Bug 95279

Summary: [Forms] Make HTMLInputElement::blur()/focus() override-able by input type
Product: WebKit Reporter: yosin
Component: FormsAssignee: yosin
Status: RESOLVED FIXED    
Severity: Normal CC: hayato, mifenton, morrita, tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 95298    
Bug Blocks: 95168    
Attachments:
Description Flags
Patch 1
none
Patch 2
none
Patch 3
none
Patch 4
none
Patch 5 none

yosin
Reported 2012-08-28 20:44:34 PDT
This patch is part of Shift+Tab focus navigation fix for multiple time input UI. On multiple fields time input UI, we would like to make focus() and blur() JavaScript methods to move focus into/out to field inside shadow DOM tree. To do this, we would like make HTMLInputElement::focus()/blur() override-able bu InputType class.
Attachments
Patch 1 (4.59 KB, patch)
2012-08-28 20:53 PDT, yosin 		no flags
DetailsFormatted DiffDiff
Patch 2 (4.71 KB, patch)
2012-08-28 20:56 PDT, yosin 		no flags
DetailsFormatted DiffDiff
Patch 3 (4.68 KB, patch)
2012-08-28 20:58 PDT, yosin 		no flags
DetailsFormatted DiffDiff
Patch 4 (4.44 KB, patch)
2012-08-28 23:42 PDT, yosin 		no flags
DetailsFormatted DiffDiff
Patch 5 (5.02 KB, patch)
2012-08-29 00:10 PDT, yosin 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
yosin
Comment 1 2012-08-28 20:53:42 PDT
Created attachment 161124 [details] Patch 1
yosin
Comment 2 2012-08-28 20:56:17 PDT
Created attachment 161125 [details] Patch 2
yosin
Comment 3 2012-08-28 20:58:08 PDT
Created attachment 161127 [details] Patch 3
yosin
Comment 4 2012-08-28 20:58:39 PDT
Comment on attachment 161127 [details] Patch 3 Could you review this patch? Thanks in advance.
Hajime Morrita
Comment 5 2012-08-28 23:04:03 PDT
Comment on attachment 161127 [details] Patch 3 View in context: https://bugs.webkit.org/attachment.cgi?id=161127&action=review > Source/WebCore/ChangeLog:9 > + override-able by InputType class if ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS I don't think we need to hide these code blocks under ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS. Overriding method conditionally can cause tricky problem.
yosin
Comment 6 2012-08-28 23:42:43 PDT
Created attachment 161146 [details] Patch 4
yosin
Comment 7 2012-08-28 23:44:38 PDT
Comment on attachment 161146 [details] Patch 4 Clearing flags on attachment: 161146 Committed r126963: <http://trac.webkit.org/changeset/126963>
yosin
Comment 8 2012-08-28 23:44:43 PDT
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 9 2012-08-28 23:59:22 PDT
Re-opened since this is blocked by 95298
yosin
Comment 10 2012-08-29 00:10:58 PDT
Created attachment 161152 [details] Patch 5
yosin
Comment 11 2012-08-29 00:12:23 PDT
Comment on attachment 161152 [details] Patch 5 Clearing flags on attachment: 161152 Committed r126966: <http://trac.webkit.org/changeset/126966>
yosin
Comment 12 2012-08-29 00:12:28 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.