| Summary: | JSC: adding support for adding LLInt opcode extensions | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Mark Lam <mark.lam> | ||||||
| Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | fpizlo, ggaren, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Mark Lam
2012-08-28 18:36:00 PDT
Created attachment 161113 [details]
Fix.
Created attachment 161114 [details]
One more time after svn up.
Comment on attachment 161114 [details]
One more time after svn up.
I like this idea of distinguishing between core opcodes emitted by the compiler and extension / optimization opcodes used by the engine. We could take this even further by separating out opcodes like op_get_by_id_* and op_put_by_id_*.
Comment on attachment 161114 [details] One more time after svn up. Rejecting attachment 161114 [details] from review queue. ggaren@apple.com does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your reviewer rights. Comment on attachment 161114 [details] One more time after svn up. Rejecting attachment 161114 [details] from commit-queue. ggaren@apple.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights. Comment on attachment 161114 [details]
One more time after svn up.
Trying cq+ again.
Comment on attachment 161114 [details] One more time after svn up. Clearing flags on attachment: 161114 Committed r126955: <http://trac.webkit.org/changeset/126955> All reviewed patches have been landed. Closing bug. |