Bug 95270
| Summary: | webkit-patch rebaseline-expectations touches files too many times | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Dirk Pranke <dpranke> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | abarth, jchaffraix |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Dirk Pranke
We are reading and writing each TestExpectations file multiple times regardless of whether there's actually any REBASELINE lines in the file or we actually did anything.
A partial fix would be to only iterate over the set of unique expectations_dict() values, rather that all of the port names. Another would be to skip rewriting the file if get_rebaselining_failures() returned an empty set.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |