Bug 95266
| Summary: | check-webkit-style gets confused when a function returns PassRefPtr | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Alexandru Chiculita <achicu> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED INVALID | ||
| Severity: | Normal | CC: | burg, kling, michelangelo |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Alexandru Chiculita
The following line confuses the style checker. I assume this is related to the patch context, as I cannot reproduce the issue without that specific patch.
PassRefPtr<CustomFilterParameter> StyleResolver::parseCustomFilterTransformParameter(const String& name, CSSValueList* values)
https://bugs.webkit.org/show_bug.cgi?id=71401#c8
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/css3..." exit_code: 1
Source/WebCore/css/StyleResolver.cpp:5264: Local variables should never be PassRefPtr (see http://webkit.org/coding/RefPtr.html). [readability/pass_ptr] [5]
Source/WebCore/css/StyleResolver.cpp:5273: Local variables should never be PassRefPtr (see http://webkit.org/coding/RefPtr.html). [readability/pass_ptr] [5]
Total errors found: 2 in 20 files
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Brian Burg
PassRefPtr is deprecated, and this style check will be removed soon.