|Summary:||Added ANDROID_GDBSERVER definition for Ant|
|Severity:||Normal||CC:||abarth, dglazkov, japhet, peter, peter+ews, webkit.review.bot|
|Version:||528+ (Nightly build)|
Description michaelbai 2012-08-28 16:54:42 PDT
Added ANDROID_GDBSERVER definition, it will replace ANDROID_TOOLCHAIN, because the ANDROID_TOOLCHAIN is only used for finding the gdbserver.
Comment 2 Peter Beverloo (cr-android ews) 2012-08-28 19:22:46 PDT
Comment on attachment 161097 [details] Patch Attachment 161097 [details] did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/13683005
Comment 3 Peter Beverloo 2012-08-29 03:16:24 PDT
Patch LGTM, but we can't land this yet. In the future you can consider using the "[Chromium]" prefix to bug titles for changes which only touch Chromium-specific code. There unfortunately is a three-way process to introduce new gyp variables, because of a circular dependency between Chromium and WebKit. The first step would be to introduce the variable in envsetup_functions.sh and add it to the GYP_DEFINES section. Then, after Chromium rolls into WebKit (which will happen roughly once per two days), this patch has to land. It should be fine to go in as it is. The last step is to wait until WebKit rolls into Chromium (which happens several times per day), after which you can start using the new variable.
Comment 4 michaelbai 2012-08-31 09:33:02 PDT
Hi Peter, The chromium side CL was landed, Would you like help to commit this?
Comment 5 Peter Beverloo 2012-08-31 09:41:41 PDT
I'll land this on Monday, as the relevant Chromium revision has to roll into WebKit as well. Adam/Nate, could you review this please? It looks good to me :-).
Comment 6 Adam Barth 2012-09-01 00:43:41 PDT
Comment on attachment 161097 [details] Patch Sure. rs=me
Comment 7 Peter Beverloo 2012-09-03 11:13:43 PDT
Comment on attachment 161097 [details] Patch Thanks, Adam! This should work fine now.
Comment 8 WebKit Review Bot 2012-09-03 11:36:42 PDT
Comment on attachment 161097 [details] Patch Clearing flags on attachment: 161097 Committed r127430: <http://trac.webkit.org/changeset/127430>
Comment 9 WebKit Review Bot 2012-09-03 11:36:46 PDT
All reviewed patches have been landed. Closing bug.