Bug 95265 – Added ANDROID_GDBSERVER definition for Ant

• Component: Platform
• Status: RESOLVED FIXED

Added ANDROID_GDBSERVER definition, it will replace ANDROID_TOOLCHAIN, because the ANDROID_TOOLCHAIN is only used for finding the gdbserver.

Created attachment 161097 [details]
Patch

[Peter Beverloo (cr-android ews)]

Comment on attachment 161097 [details]
Patch

Attachment 161097 [details] did not pass cr-android-ews (chromium-android):
Output: http://queues.webkit.org/results/13683005

[Peter Beverloo]

Patch LGTM, but we can't land this yet. In the future you can consider using the "[Chromium]" prefix to bug titles for changes which only touch Chromium-specific code.

There unfortunately is a three-way process to introduce new gyp variables, because of a circular dependency between Chromium and WebKit.

The first step would be to introduce the variable in envsetup_functions.sh and add it to the GYP_DEFINES section.

Then, after Chromium rolls into WebKit (which will happen roughly once per two days), this patch has to land. It should be fine to go in as it is.

The last step is to wait until WebKit rolls into Chromium (which happens several times per day), after which you can start using the new variable.

Hi Peter,

The chromium side CL was landed, Would you like help to commit this?

[Peter Beverloo]

I'll land this on Monday, as the relevant Chromium revision has to roll into WebKit as well. Adam/Nate, could you review this please? It looks good to me :-).

[Adam Barth]

Comment on attachment 161097 [details]
Patch

Sure.  rs=me

[Peter Beverloo]

Comment on attachment 161097 [details]
Patch

Thanks, Adam! This should work fine now.

[WebKit Review Bot]

Comment on attachment 161097 [details]
Patch

Clearing flags on attachment: 161097

Committed r127430: <http://trac.webkit.org/changeset/127430>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.