Bug 95264

Summary: [EFL] Move several files to remove webkit1 dependency from WebCore.
Product: WebKit Reporter: Ryuan Choi <ryuan.choi>
Component: WebKit EFLAssignee: Ryuan Choi <ryuan.choi>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, lucas.de.marchi, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 95307    
Attachments:
Description Flags
Patch
none
Patch none

Ryuan Choi
Reported 2012-08-28 16:49:26 PDT
Below files are WebKit1 specfic files so that they should be in WebKit/efl. - platform/efl/ColorChooserEfl.cpp - platform/efl/PopupMenuEfl.cpp - platform/efl/SearchPopupMenuEfl.cpp
Attachments
Patch (32.22 KB, patch)
2012-08-28 17:00 PDT, Ryuan Choi 		no flags
DetailsFormatted DiffDiff
Patch (33.24 KB, patch)
2012-08-28 19:19 PDT, Ryuan Choi 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ryuan Choi
Comment 1 2012-08-28 17:00:21 PDT
Created attachment 161093 [details] Patch
Raphael Kubo da Costa (:rakuco)
Comment 2 2012-08-28 17:49:16 PDT
Comment on attachment 161093 [details] Patch Not having a dependency on WebCoreSupport in WebCore is definitely a plus. Do you know if these files are normally in the WebKit layer for other ports as well?
Ryuan Choi
Comment 3 2012-08-28 18:07:16 PDT
(In reply to comment #2) > (From update of attachment 161093 [details]) > Not having a dependency on WebCoreSupport in WebCore is definitely a plus. Do you know if these files are normally in the WebKit layer for other ports as well? It depends on port. For Qt, they are in WebCoreSupport. But for gtk, they are in WebCore/platform. In case of Gtk port, they don't have dependency on WebCoreSupport.
Early Warning System Bot
Comment 4 2012-08-28 19:06:22 PDT
Comment on attachment 161093 [details] Patch Attachment 161093 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/13690002
Ryuan Choi
Comment 5 2012-08-28 19:19:57 PDT
Created attachment 161117 [details] Patch
Gyuyoung Kim
Comment 6 2012-08-29 00:42:06 PDT
Comment on attachment 161117 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=161117&action=review LGTM > Source/WebKit/efl/WebCoreSupport/PopupMenuEfl.h:36 > + PopupMenuEfl(PopupMenuClient*); Could you please add *explicit* keyword in new bug ? > Source/WebKit/efl/WebCoreSupport/SearchPopupMenuEfl.h:31 > + SearchPopupMenuEfl(PopupMenuClient*); ditto.
WebKit Review Bot
Comment 7 2012-08-29 01:02:31 PDT
Comment on attachment 161117 [details] Patch Clearing flags on attachment: 161117 Committed r126971: <http://trac.webkit.org/changeset/126971>
WebKit Review Bot
Comment 8 2012-08-29 01:02:35 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.