Bug 95259

Summary: Remove extraneous includes (Node.h, Document.h, Element.h, RenderObject.h)
Product: WebKit Reporter: nbhargava
Component: New BugsAssignee: nbhargava
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, eric.carlson, eric, feature-media-reviews, gtk-ews, gustavo, japhet, mifenton, peter+ews, philn, tkent, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch for landing none

nbhargava
Reported 2012-08-28 16:20:37 PDT
Remove extraneous includes (Node.h, Document.h, Element.h, RenderObject.h)
Attachments
Patch (30.78 KB, patch)
2012-08-28 16:23 PDT, nbhargava 		no flags
DetailsFormatted DiffDiff
Patch (30.81 KB, patch)
2012-08-28 16:33 PDT, nbhargava 		no flags
DetailsFormatted DiffDiff
Patch (30.83 KB, patch)
2012-08-28 16:46 PDT, nbhargava 		no flags
DetailsFormatted DiffDiff
Patch (31.56 KB, patch)
2012-08-29 13:14 PDT, nbhargava 		no flags
DetailsFormatted DiffDiff
Patch (30.77 KB, patch)
2012-08-29 16:13 PDT, nbhargava 		no flags
DetailsFormatted DiffDiff
Patch for landing (28.88 KB, patch)
2012-08-30 16:25 PDT, nbhargava 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
nbhargava
Comment 1 2012-08-28 16:23:13 PDT
Created attachment 161083 [details] Patch
nbhargava
Comment 2 2012-08-28 16:26:06 PDT
Comment on attachment 161083 [details] Patch This patch removes several #includes from across the project that are unnecessary or over-inclusive. The focus is primarily on Node.h, Document.h, Element.h, and RenderObject.h though some other includes may be added or removed to make sure it still compiles. There is a slight compile-time performance boost but the main purpose of this was to remove some excess and make further compile-time analysis easier.
nbhargava
Comment 3 2012-08-28 16:33:09 PDT
Created attachment 161087 [details] Patch
nbhargava
Comment 4 2012-08-28 16:46:58 PDT
Created attachment 161089 [details] Patch
kov's GTK+ EWS bot
Comment 5 2012-08-28 17:09:04 PDT
Comment on attachment 161089 [details] Patch Attachment 161089 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/13663487
Gyuyoung Kim
Comment 6 2012-08-28 17:13:41 PDT
Comment on attachment 161089 [details] Patch Attachment 161089 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/13665445
Build Bot
Comment 7 2012-08-28 17:24:53 PDT
Comment on attachment 161089 [details] Patch Attachment 161089 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/13659540
Early Warning System Bot
Comment 8 2012-08-28 17:51:12 PDT
Comment on attachment 161089 [details] Patch Attachment 161089 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/13660513
Early Warning System Bot
Comment 9 2012-08-28 18:02:57 PDT
Comment on attachment 161089 [details] Patch Attachment 161089 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/13662467
WebKit Review Bot
Comment 10 2012-08-28 18:18:56 PDT
Comment on attachment 161089 [details] Patch Attachment 161089 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13651590
Peter Beverloo (cr-android ews)
Comment 11 2012-08-28 18:21:32 PDT
Comment on attachment 161089 [details] Patch Attachment 161089 [details] did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/13658559
Build Bot
Comment 12 2012-08-28 20:13:35 PDT
Comment on attachment 161089 [details] Patch Attachment 161089 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/13685019
nbhargava
Comment 13 2012-08-29 13:14:05 PDT
Created attachment 161294 [details] Patch
Build Bot
Comment 14 2012-08-29 13:34:34 PDT
Comment on attachment 161294 [details] Patch Attachment 161294 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/13694357
kov's GTK+ EWS bot
Comment 15 2012-08-29 13:48:54 PDT
Comment on attachment 161294 [details] Patch Attachment 161294 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/13687346
Early Warning System Bot
Comment 16 2012-08-29 14:14:02 PDT
Comment on attachment 161294 [details] Patch Attachment 161294 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/13687353
Build Bot
Comment 17 2012-08-29 14:18:59 PDT
Comment on attachment 161294 [details] Patch Attachment 161294 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/13694369
Early Warning System Bot
Comment 18 2012-08-29 14:34:50 PDT
Comment on attachment 161294 [details] Patch Attachment 161294 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/13689401
Gyuyoung Kim
Comment 19 2012-08-29 14:56:19 PDT
Comment on attachment 161294 [details] Patch Attachment 161294 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/13687372
Peter Beverloo (cr-android ews)
Comment 20 2012-08-29 15:09:19 PDT
Comment on attachment 161294 [details] Patch Attachment 161294 [details] did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/13693419
nbhargava
Comment 21 2012-08-29 16:13:43 PDT
Created attachment 161349 [details] Patch
Gyuyoung Kim
Comment 22 2012-08-29 18:40:19 PDT
Comment on attachment 161349 [details] Patch Attachment 161349 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/13680499
Gyuyoung Kim
Comment 23 2012-08-29 18:55:21 PDT
Comment on attachment 161349 [details] Patch Attachment 161349 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/13688532
nbhargava
Comment 24 2012-08-30 16:25:31 PDT
Created attachment 161580 [details] Patch for landing
WebKit Review Bot
Comment 25 2012-08-31 12:11:10 PDT
Comment on attachment 161580 [details] Patch for landing Clearing flags on attachment: 161580 Committed r127300: <http://trac.webkit.org/changeset/127300>
WebKit Review Bot
Comment 26 2012-08-31 12:11:15 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.