[Mac] Add iconURL to WebNotification

• Component: DOM
• Status: RESOLVED FIXED

[Jon Lee]

On the WK1 side WebNotification was missing an accessor to the notification's iconURL. It is already available on WK2.

[Radar WebKit Bug Importer]

<rdar://problem/12192060>

[Jon Lee]

Created attachment 161065 [details]
Patch

[Alexey Proskuryakov]

Comment on attachment 161065 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=161065&action=review

> Source/WebKit/mac/WebView/WebNotification.mm:118
> +    ASSERT(core(self));
> +    return core(self)->iconURL();

I'm not sure if this kind of ASSERT is useful. We'd get a very unambiguous crash in actual code, so there is no need to help debugging by adding the assertion.

[Jon Lee]

(In reply to comment #3)
> (From update of attachment 161065 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=161065&action=review
> 
> > Source/WebKit/mac/WebView/WebNotification.mm:118
> > +    ASSERT(core(self));
> > +    return core(self)->iconURL();
> 
> I'm not sure if this kind of ASSERT is useful. We'd get a very unambiguous crash in actual code, so there is no need to help debugging by adding the assertion.

I can remove it, as well as all the other instances in the file.

[Jon Lee]

Committed r127009: <http://trac.webkit.org/changeset/127009>