Bug 95232 – [Mac] Add testRunner.dumpWebNotificationCallbacks() to DRT

• Component: Tools / Tests
• Status: RESOLVED WONTFIX

[Jon Lee]

With this flag set, test output will include events that mimic what would happen on the platform level, such as a user clicking on a notification, or the platform showing a notification.

[Radar WebKit Bug Importer]

<rdar://problem/12190776>

[Jon Lee]

Created attachment 161308 [details]
Patch

[Alexey Proskuryakov]

Comment on attachment 161308 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=161308&action=review

> Tools/DumpRenderTree/mac/UIDelegate.mm:294
> +    printf("REQUESTED WEB NOTIFICATION PERMISSION FOR %s\n", [[origin stringValue] UTF8String]);

Should this be guarded by gTestRunner->dumpWebNotificationCallbacks?

[Jon Lee]

Comment on attachment 161308 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=161308&action=review

>> Tools/DumpRenderTree/mac/UIDelegate.mm:294
>> +    printf("REQUESTED WEB NOTIFICATION PERMISSION FOR %s\n", [[origin stringValue] UTF8String]);
> 
> Should this be guarded by gTestRunner->dumpWebNotificationCallbacks?

Yes! Thank you.

[Jon Lee]

Committed r127171: <http://trac.webkit.org/changeset/127171>

[WebKit Review Bot]

Re-opened since this is blocked by 95505

[Jon Lee]

ap did not feel that this additional output added value for tests, and that the javascript events should suffice. rolling out in bug 95505.