Bug 95231

Summary: Add directory generated by Eclipse to .gitignore
Product: WebKit Reporter: Mario Sanchez Prada <mario>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: kling, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch proposal none

Mario Sanchez Prada
Reported 2012-08-28 12:36:52 PDT
Add .settings directory, used to store project specific settings in Eclipse, and also by some plugins (e.g. CDT) to .gitignore.
Attachments
Patch proposal (1.17 KB, patch)
2012-08-28 12:40 PDT, Mario Sanchez Prada 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mario Sanchez Prada
Comment 1 2012-08-28 12:40:12 PDT
Created attachment 161036 [details] Patch proposal Adding Andreas Kling as reviewer as he already reviewed a similar patch some time ago (see bug 79463)
Mario Sanchez Prada
Comment 2 2012-08-28 12:40:58 PDT
Now actually adding Andreas Kling to CC...
Andreas Kling
Comment 3 2012-08-28 12:57:33 PDT
Comment on attachment 161036 [details] Patch proposal Boom, r+!
Mario Sanchez Prada
Comment 4 2012-08-28 13:52:23 PDT
Comment on attachment 161036 [details] Patch proposal Thanks
WebKit Review Bot
Comment 5 2012-08-28 15:59:00 PDT
Comment on attachment 161036 [details] Patch proposal Clearing flags on attachment: 161036 Committed r126936: <http://trac.webkit.org/changeset/126936>
WebKit Review Bot
Comment 6 2012-08-28 15:59:03 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.