Bug 95213

Summary: [New Multicolumn] Rename some RenderFlowThread methods and add some arguments to functions
Product: WebKit Reporter: Dave Hyatt <hyatt>
Component: Layout and RenderingAssignee: Dave Hyatt <hyatt>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch simon.fraser: review+

Description Dave Hyatt 2012-08-28 09:51:33 PDT
Rename paintIntoRegion and hitTestRegion so that they can take a flow thread portion that isn't necessarily tied to the flow thread portion of the entire region. In order to work with region sets like the new multicolumn layout, these functions have to be able to paint a portion of a portion.
Comment 1 Dave Hyatt 2012-08-28 09:55:50 PDT
Created attachment 161002 [details]
Patch
Comment 2 Simon Fraser (smfr) 2012-08-28 10:05:57 PDT
Comment on attachment 161002 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=161002&action=review

> Source/WebCore/ChangeLog:9
> +        Rename regionRect()/setRegionRect()/m_regionRect on RenderRegion to be flowThreadPortionRect instead.

flowThreadPortion is a bit of a mouthful, but I can't think of anything better.
Comment 3 Dave Hyatt 2012-08-28 10:59:08 PDT
Landed in r126895.