Bug 95199

Summary: [EFL] WebKit EFL updates view on HTTP 204 response
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit EFLAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, kenneth, lucas.de.marchi, luiz, rakuco, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Chris Dumez 2012-08-28 07:25:42 PDT 
WebKitEFL currently updates the view on HTTP 204 response (No content). Such response should be ignored.
This causes the following test case to fail:
  http/tests/navigation/response204.html
Comment 1 Chris Dumez 2012-08-28 07:29:52 PDT 
Created attachment 160973 [details]
Patch
Comment 2 Kenneth Rohde Christiansen 2012-08-28 07:46:39 PDT 
Comment on attachment 160973 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=160973&action=review

> Source/WebKit2/UIProcess/API/efl/ewk_view_policy_client.cpp:63
> +    if (resourceResponse.httpStatusCode() == 204) {

Using #include "HTTPStatusCodes.h"  would be better
Comment 3 Chris Dumez 2012-08-28 07:55:01 PDT 
Created attachment 160981 [details]
Patch

Take Kenneth's feedback into consideration.
Comment 4 WebKit Review Bot 2012-08-28 08:46:31 PDT 
Comment on attachment 160981 [details]
Patch

Clearing flags on attachment: 160981

Committed r126884: <http://trac.webkit.org/changeset/126884>
Comment 5 WebKit Review Bot 2012-08-28 08:46:35 PDT 
All reviewed patches have been landed.  Closing bug.