Bug 95170

Summary: [WK2] Use explicit constructor in PageClientImpl
Product: WebKit Reporter: Kangil Han <kangil.han>
Component: WebKit2Assignee: Kangil Han <kangil.han>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, gustavo, gyuyoung.kim, mrobinson, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
patch
mrobinson: review-
patch none

Kangil Han
Reported 2012-08-27 23:09:18 PDT
Added explicit keyword to constructor in PageClientImpl.
Attachments
patch (1.78 KB, patch)
2012-08-27 23:10 PDT, Kangil Han 		mrobinson: review-
DetailsFormatted DiffDiff
patch (1.81 KB, patch)
2012-08-28 19:40 PDT, Kangil Han 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kangil Han
Comment 1 2012-08-27 23:10:56 PDT
Created attachment 160906 [details] patch
WebKit Review Bot
Comment 2 2012-08-27 23:13:19 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Martin Robinson
Comment 3 2012-08-28 19:06:24 PDT
Comment on attachment 160906 [details] patch Nowhere in the patch or the bug do you explain why you are making this change... Does it fix or prevent any bugs?
Kangil Han
Comment 4 2012-08-28 19:18:22 PDT
(In reply to comment #3) > (From update of attachment 160906 [details]) > Nowhere in the patch or the bug do you explain why you are making this change... Does it fix or prevent any bugs? Yes, you are right. I didn't explain why explicit keyword is needed in this patch. I will get back with updated changelog! Thanks!
Kangil Han
Comment 5 2012-08-28 19:40:50 PDT
Created attachment 161119 [details] patch Done!
WebKit Review Bot
Comment 6 2012-08-28 22:09:43 PDT
Comment on attachment 161119 [details] patch Clearing flags on attachment: 161119 Committed r126958: <http://trac.webkit.org/changeset/126958>
WebKit Review Bot
Comment 7 2012-08-28 22:09:47 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.