Bug 95141

Summary:

Structure check hoisting should abstain if the OSR entry's must-handle value for the respective variable has a different structure

Product:

WebKit

Reporter:

Filip Pizlo <fpizlo>

Component:

JavaScriptCore

Assignee:

Filip Pizlo <fpizlo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

barraclough, ggaren, mhahnenberg, msaboff, oliver

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
the patch	mhahnenberg: review+

Description Filip Pizlo 2012-08-27 15:37:05 PDT

Patch forthcoming.

<rdar://problem/12170401>

Comment 1 Filip Pizlo 2012-08-27 15:38:23 PDT

Created attachment 160828 [details]
the patch

Comment 2 Mark Hahnenberg 2012-08-27 15:42:49 PDT

Comment on attachment 160828 [details]
the patch

A test would be nice. Looks good otherwise.

Comment 3 Filip Pizlo 2012-08-27 17:40:47 PDT

Landed in http://trac.webkit.org/changeset/126826

Comment 4 Filip Pizlo 2012-08-28 11:01:06 PDT

(In reply to comment #2)
> (From update of attachment 160828 [details])
> A test would be nice. Looks good otherwise.

I tried to come up with a test.  But that requires perfect timing to make something evil happen right at the time that OSR kicks in.  I decided that even if I succeeded in making such a test, it would be extremely fragile and probably not worth it.