Bug 95141 - Structure check hoisting should abstain if the OSR entry's must-handle value for the respective variable has a different structure
Summary: Structure check hoisting should abstain if the OSR entry's must-handle value ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2012-08-27 15:37 PDT by Filip Pizlo
Modified: 2012-08-28 11:01 PDT (History)
5 users (show)

See Also:


Attachments
the patch (3.49 KB, patch)
2012-08-27 15:38 PDT, Filip Pizlo
mhahnenberg: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2012-08-27 15:37:05 PDT
Patch forthcoming.

<rdar://problem/12170401>
Comment 1 Filip Pizlo 2012-08-27 15:38:23 PDT
Created attachment 160828 [details]
the patch
Comment 2 Mark Hahnenberg 2012-08-27 15:42:49 PDT
Comment on attachment 160828 [details]
the patch

A test would be nice. Looks good otherwise.
Comment 3 Filip Pizlo 2012-08-27 17:40:47 PDT
Landed in http://trac.webkit.org/changeset/126826
Comment 4 Filip Pizlo 2012-08-28 11:01:06 PDT
(In reply to comment #2)
> (From update of attachment 160828 [details])
> A test would be nice. Looks good otherwise.

I tried to come up with a test.  But that requires perfect timing to make something evil happen right at the time that OSR kicks in.  I decided that even if I succeeded in making such a test, it would be extremely fragile and probably not worth it.