Bug 95095

Summary: Simplify cloning of inline style (below Node.cloneNode)
Product: WebKit Reporter: Andreas Kling <kling>
Component: DOMAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, koivisto, macpherson, menard, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Andreas Kling
Reported 2012-08-27 09:36:40 PDT
We should just use StylePropertySet::copy() instead of cloning everything manually in ElementAttributeData::cloneDataFrom().
Attachments
Patch (4.54 KB, patch)
2012-08-27 09:37 PDT, Andreas Kling 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2012-08-27 09:37:07 PDT
Created attachment 160733 [details] Patch
Andreas Kling
Comment 2 2012-08-27 11:04:49 PDT
CC'ing Antti who is a pretty cool guy.
Eric Seidel (no email)
Comment 3 2012-08-27 13:14:10 PDT
Comment on attachment 160733 [details] Patch Looks reasonable.
WebKit Review Bot
Comment 4 2012-08-28 06:15:38 PDT
Comment on attachment 160733 [details] Patch Clearing flags on attachment: 160733 Committed r126872: <http://trac.webkit.org/changeset/126872>
WebKit Review Bot
Comment 5 2012-08-28 06:15:41 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.