Bug 95088

Summary: Web Inspector: Debugger should break on failed assertions in Break on exceptions mode.
Product: WebKit Reporter: Vsevolod Vlasov <vsevik>
Component: Web Inspector (Deprecated)Assignee: Vsevolod Vlasov <vsevik>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch yurys: review+

Vsevolod Vlasov
Reported 2012-08-27 08:02:55 PDT
Patch to follow.
Attachments
Patch (10.87 KB, patch)
2012-08-27 08:12 PDT, Vsevolod Vlasov 		yurys: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Vsevolod Vlasov
Comment 1 2012-08-27 08:12:28 PDT
Created attachment 160723 [details] Patch
Yury Semikhatsky
Comment 2 2012-08-27 08:25:52 PDT
Comment on attachment 160723 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=160723&action=review > Source/WebCore/inspector/InspectorInstrumentation.cpp:894 > + if (InspectorDebuggerAgent* debuggerAgent = instrumentingAgents->inspectorDebuggerAgent()) I would call console agent first in order to have the message appear in the console before pausing. We had user complains about exceptions being logged only after you resume.
Vsevolod Vlasov
Comment 3 2012-08-27 08:43:05 PDT
Committed r126764: <http://trac.webkit.org/changeset/126764>
Note You need to log in before you can comment on or make changes to this bug.