Bug 95027
| Summary: | r126683 broke fast/block/float/016.html | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Mark Lam <mark.lam> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | jchaffraix, robert |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Mark Lam
Change set http://trac.webkit.org/changeset/126683 (https://bugs.webkit.org/show_bug.cgi?id=84286) caused a regression in fast/block/float/016.html on platform mac.
Here's an example of the failure result diff:
http://build.webkit.org/results/Apple%20Lion%20Release%20WK1%20(Tests)/r126683%20(2788)/fast/block/float/016-pretty-diff.html
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Robert Hogan
The new result is fine - it's failing because it's suppressed twice - once by me, once by someone else. I didn't notice this after suppressing the result so sorry for that.
I'm rebaselineing these today - I've already run webkit-patch rebaseline-expectations. So once I've reviewed the output I plan to unsuppress the hundred or so tests rebaselined by this patch.
Mark Lam
r126700: <http://trac.webkit.org/changeset/126700>
Mark Lam
Mean to say: the test was skipped for platform mac in r126700: <http://trac.webkit.org/changeset/126700>.
Alexey Proskuryakov
Robert, Julien, should we roll out r126683?
Robert Hogan
(In reply to comment #4)
> Robert, Julien, should we roll out r126683?
No - see comment #1. This test is unsuppressed by me now - but is still suppressed by:
// Requires rebaseline after bug 85031
BUGWK85565 : fast/block/float/016.html = IMAGE