Bug 95026

Summary: Frequent crashes in PluginView::scriptObject under runtimeObjectCustomGetOwnPropertySlot
Product: WebKit Reporter: Jack van Soest <jackvans>
Component: Plug-insAssignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: abecsi, beidson, gyuyoung.kim, rakuco, webkit.review.bot
Priority: P1 Keywords: InRadar, Regression
Version: 528+ (Nightly build)   
Hardware: Mac (Intel)   
OS: OS X 10.8   
URL: http://travelbird.nl/3265/wijnhellingen-moezel/?ref=adsalsa&utm_source=adsalsa&utm_medium=email&utm_campaign=nl-wk34-2012-to-rei-hotel-hutter&utm_content=a4
Attachments:
Description Flags
Crash log
none
Patch v1 - Fix + regression test aestes: review+

Description Jack van Soest 2012-08-26 00:27:35 PDT
Created attachment 160594 [details]
Crash log

Webkit suddenly crashes. It happens daily. With Safari no problems
Comment 1 Alexey Proskuryakov 2012-08-27 10:54:15 PDT
Brady, this sounds related to async instantiation.

<rdar://problem/12142226>
Comment 2 Brady Eidson 2012-09-04 16:49:06 PDT
*** Bug 95692 has been marked as a duplicate of this bug. ***
Comment 3 Brady Eidson 2012-09-04 16:50:44 PDT
Dupe https://bugs.webkit.org/show_bug.cgi?id=95692 points out that this happens - even with synchronous initialization - after the plugin fails to initialize.

The code change to fix this is simple.  I'm working on a plugin test for regression testing that fix.
Comment 4 Brady Eidson 2012-09-04 17:26:17 PDT
Created attachment 162136 [details]
Patch v1 - Fix + regression test
Comment 5 Andy Estes 2012-09-04 18:14:02 PDT
Comment on attachment 162136 [details]
Patch v1 - Fix + regression test

r=me, but you should let the EWS tell you this won't break a non-Mac build before landing.
Comment 6 Brady Eidson 2012-09-04 18:16:24 PDT
(In reply to comment #5)
> (From update of attachment 162136 [details])
> r=me, but you should let the EWS tell you this won't break a non-Mac build before landing.

Have been waiting patiently since I submitted to EWS.  Thanks.
Comment 7 Brady Eidson 2012-09-05 08:38:55 PDT
http://trac.webkit.org/changeset/127595