Bug 95019

Summary: [BlackBerry] Shrink the in-region nested scrollable list as soon as we can
Product: WebKit Reporter: Antonio Gomes <tonikitoo>
Component: WebKit BlackBerryAssignee: Antonio Gomes <tonikitoo>
Status: RESOLVED FIXED    
Severity: Normal CC: anilsson, gmak, rwlbuis, staikos, tonikitoo, yong.li.webkit
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 95020    
Attachments:
Description Flags
patch
none
patch rwlbuis: review+

Antonio Gomes
Reported 2012-08-25 19:35:59 PDT
That can be done as soon as the client actually starts scrolling a given layer A. All other layers cached, if any, can be dismissed at this point.
Attachments
patch (6.82 KB, patch)
2012-08-25 19:44 PDT, Antonio Gomes 		no flags
DetailsFormatted DiffDiff
patch (6.82 KB, patch)
2012-08-26 22:18 PDT, Antonio Gomes 		rwlbuis: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Antonio Gomes
Comment 1 2012-08-25 19:44:42 PDT
Created attachment 160584 [details] patch
George Staikos
Comment 2 2012-08-25 20:15:22 PDT
Comment on attachment 160584 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=160584&action=review > Source/WebKit/blackberry/Api/InRegionScroller.cpp:162 > + while(it != end) { missing space? > Source/WebKit/blackberry/ChangeLog:13 > + Patch providesa simple solution to that. Missing space?
Antonio Gomes
Comment 3 2012-08-26 22:18:05 PDT
Created attachment 160632 [details] patch (In reply to comment #2) > (From update of attachment 160584 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=160584&action=review > > > Source/WebKit/blackberry/Api/InRegionScroller.cpp:162 > > + while(it != end) { > > missing space? > > > Source/WebKit/blackberry/ChangeLog:13 > > + Patch providesa simple solution to that. > > Missing space? Both fixed.
Rob Buis
Comment 4 2012-08-27 06:44:39 PDT
Comment on attachment 160632 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=160632&action=review LGTM. > Source/WebKit/blackberry/Api/InRegionScroller.cpp:172 > + // ::erase invalidades the iterators. Typo: invalidates > Source/WebKit/blackberry/ChangeLog:10 > + of each layer, and on the diretion user swipes its finger. Typo: direction
Antonio Gomes
Comment 5 2012-08-27 08:55:14 PDT
https://trac.webkit.org/changeset/126767
Note You need to log in before you can comment on or make changes to this bug.