Bug 94995

Summary: [chromium] CCThreadImpl / WebCompositorImpl shouldn't compile from webkit when use_libcc_for_compositor=1
Product: WebKit Reporter: James Robinson <jamesr>
Component: New BugsAssignee: James Robinson <jamesr>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dpranke, enne, fishd, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 95211, 95214    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch abarth: review+

Description James Robinson 2012-08-24 18:22:18 PDT 
[chromium] Put CCThreadImpl / WebCompositorImpl in webcore_chromium_compositor_files gyp section
Comment 1 James Robinson 2012-08-24 18:22:48 PDT 
Created attachment 160538 [details]
Patch
Comment 2 Adrienne Walker 2012-08-27 10:48:18 PDT 
Comment on attachment 160538 [details]
Patch

Should these files be moved too, for consistency? It looks like everything in platform/chromium/support goes into webcore_platform_support_files except for these.
Comment 3 James Robinson 2012-08-27 11:03:17 PDT 
Probably wouldn't hurt but wouldn't help too much either - they're getting nuked pretty soon.
Comment 4 Adrienne Walker 2012-08-27 13:12:06 PDT 
Comment on attachment 160538 [details]
Patch

R=me.  If they're just going to go away soon, then not moving them sounds reasonable.
Comment 5 WebKit Review Bot 2012-08-27 16:01:09 PDT 
Comment on attachment 160538 [details]
Patch

Clearing flags on attachment: 160538

Committed r126813: <http://trac.webkit.org/changeset/126813>
Comment 6 WebKit Review Bot 2012-08-27 16:01:12 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 WebKit Review Bot 2012-08-28 09:47:35 PDT 
Re-opened since this is blocked by 95211
Comment 8 James Robinson 2012-08-28 12:27:26 PDT 
With use_libcc_for_compositor==0, I need to link WebCompositorImpl directly into the 'webkit' target along with the other webcore_platform_support_files.  Not sure how cr-linux is green on this.
Comment 9 James Robinson 2012-08-28 23:17:14 PDT 
Created attachment 161141 [details]
Patch
Comment 10 James Robinson 2012-08-28 23:17:44 PDT 
More direct - this just excludes those files from the 'webkit' target.  Trybots are much happier with this.
Comment 11 Adam Barth 2012-08-29 09:47:25 PDT 
Comment on attachment 161141 [details]
Patch

ok
Comment 12 James Robinson 2012-08-29 10:58:41 PDT 
Committed r127020: <http://trac.webkit.org/changeset/127020>