Bug 94995

Summary: [chromium] CCThreadImpl / WebCompositorImpl shouldn't compile from webkit when use_libcc_for_compositor=1
Product: WebKit Reporter: James Robinson <jamesr>
Component: New BugsAssignee: James Robinson <jamesr>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dpranke, enne, fishd, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 95211, 95214    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch abarth: review+

James Robinson
Reported 2012-08-24 18:22:18 PDT
[chromium] Put CCThreadImpl / WebCompositorImpl in webcore_chromium_compositor_files gyp section
Attachments
Patch (2.58 KB, patch)
2012-08-24 18:22 PDT, James Robinson 		no flags
DetailsFormatted DiffDiff
Patch (1.68 KB, patch)
2012-08-28 23:17 PDT, James Robinson 		abarth: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
James Robinson
Comment 1 2012-08-24 18:22:48 PDT
Created attachment 160538 [details] Patch
Adrienne Walker
Comment 2 2012-08-27 10:48:18 PDT
Comment on attachment 160538 [details] Patch Should these files be moved too, for consistency? It looks like everything in platform/chromium/support goes into webcore_platform_support_files except for these.
James Robinson
Comment 3 2012-08-27 11:03:17 PDT
Probably wouldn't hurt but wouldn't help too much either - they're getting nuked pretty soon.
Adrienne Walker
Comment 4 2012-08-27 13:12:06 PDT
Comment on attachment 160538 [details] Patch R=me. If they're just going to go away soon, then not moving them sounds reasonable.
WebKit Review Bot
Comment 5 2012-08-27 16:01:09 PDT
Comment on attachment 160538 [details] Patch Clearing flags on attachment: 160538 Committed r126813: <http://trac.webkit.org/changeset/126813>
WebKit Review Bot
Comment 6 2012-08-27 16:01:12 PDT
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 7 2012-08-28 09:47:35 PDT
Re-opened since this is blocked by 95211
James Robinson
Comment 8 2012-08-28 12:27:26 PDT
With use_libcc_for_compositor==0, I need to link WebCompositorImpl directly into the 'webkit' target along with the other webcore_platform_support_files. Not sure how cr-linux is green on this.
James Robinson
Comment 9 2012-08-28 23:17:14 PDT
Created attachment 161141 [details] Patch
James Robinson
Comment 10 2012-08-28 23:17:44 PDT
More direct - this just excludes those files from the 'webkit' target. Trybots are much happier with this.
Adam Barth
Comment 11 2012-08-29 09:47:25 PDT
Comment on attachment 161141 [details] Patch ok
James Robinson
Comment 12 2012-08-29 10:58:41 PDT
Committed r127020: <http://trac.webkit.org/changeset/127020>
Note You need to log in before you can comment on or make changes to this bug.