Bug 94962

Summary:

Don't create a new ResourceRequest if delegate returns the same NSURLRequest we passed it

Product:

WebKit

Reporter:

Pratik Solanki <psolanki>

Component:

WebKit Misc.

Assignee:

Pratik Solanki <psolanki>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, psolanki

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	ggaren: review+

Pratik Solanki

Reported 2012-08-24 11:32:28 PDT

WebFrameLoaderClient::dispatchWillSendRequest does if (implementations->willSendRequestFunc) request = (NSURLRequest *)CallResourceLoadDelegate(implementations->willSendRequestFunc, webView, @selector(webView:resource:willSendRequest:redirectResponse:fromDataS request in this case is a ResourceRequest& that is passed in. This means we always create a new ResourceRequest. This can be wasteful in cases where the client decides to return us the exact same NSURLRequest without modifying it.

Attachments
Patch (2.52 KB, patch) 2012-08-24 12:48 PDT, Pratik Solanki	no flags	Details Formatted Diff Diff
Patch (2.52 KB, patch) 2012-08-24 12:52 PDT, Pratik Solanki	ggaren: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.