Bug 94950

Summary: Fix a crash in SourceBufferList.remove().
Product: WebKit Reporter: Aaron Colwell <acolwell>
Component: New BugsAssignee: Aaron Colwell <acolwell>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, feature-media-reviews, haraken, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Aaron Colwell
Reported 2012-08-24 10:30:46 PDT
Fix a crash in SourceBufferList.remove().
Attachments
Patch (1.82 KB, patch)
2012-08-24 10:40 PDT, Aaron Colwell 		no flags
DetailsFormatted DiffDiff
Patch (5.11 KB, patch)
2012-08-30 09:04 PDT, Aaron Colwell 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Aaron Colwell
Comment 1 2012-08-24 10:40:36 PDT
Created attachment 160448 [details] Patch
Kentaro Hara
Comment 2 2012-08-24 17:43:17 PDT
Could you add a test for your change?
Eric Seidel (no email)
Comment 3 2012-08-27 13:23:13 PDT
Comment on attachment 160448 [details] Patch We'll need a test if possible. (Or an explanation in the ChangeLog why testing is impossible/iimpractical.)
Aaron Colwell
Comment 4 2012-08-28 11:16:03 PDT
Closing in favor of https://bugs.webkit.org/show_bug.cgi?id=95217 Attempting to create a test for this bug exposed a larger problem with the code.
Aaron Colwell
Comment 5 2012-08-28 13:18:33 PDT
Reopening. eric.carlson@ asked me to keep the fix for this separate from https://bugs.webkit.org/show_bug.cgi?id=95217
Aaron Colwell
Comment 6 2012-08-30 09:04:13 PDT
Created attachment 161486 [details] Patch
WebKit Review Bot
Comment 7 2012-08-30 09:51:55 PDT
Comment on attachment 161486 [details] Patch Clearing flags on attachment: 161486 Committed r127153: <http://trac.webkit.org/changeset/127153>
WebKit Review Bot
Comment 8 2012-08-30 09:51:58 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.