Bug 94940

Summary: Web Inspector: make ConsoleView listen to the JavaScriptContextManager
Product: WebKit Reporter: Pavel Feldman <pfeldman>
Component: Web Inspector (Deprecated)Assignee: Pavel Feldman <pfeldman>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch vsevik: review+

Pavel Feldman
Reported 2012-08-24 08:42:01 PDT
Otherwise, model element is pushing data into the UI.
Attachments
Patch (11.99 KB, patch)
2012-08-24 09:00 PDT, Pavel Feldman 		no flags
DetailsFormatted DiffDiff
Patch (12.98 KB, patch)
2012-08-24 09:02 PDT, Pavel Feldman 		vsevik: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2012-08-24 09:00:05 PDT
Created attachment 160434 [details] Patch
Pavel Feldman
Comment 2 2012-08-24 09:02:14 PDT
Created attachment 160435 [details] Patch
Vsevolod Vlasov
Comment 3 2012-08-25 01:50:04 PDT
Comment on attachment 160435 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=160435&action=review > Source/WebCore/inspector/front-end/JavaScriptContextManager.js:56 > + var result = []; We now have Object.values(this._frameIdToContext) > Source/WebCore/inspector/front-end/ParsedURL.js:-101 > - if (trimmedHref.startsWith("data:") || trimmedHref.startsWith("blob:")) Please mention this drive by in the changelog.
Pavel Feldman
Comment 4 2012-08-26 11:42:33 PDT
Committed r126709: <http://trac.webkit.org/changeset/126709>
Note You need to log in before you can comment on or make changes to this bug.