Bug 94908

Summary: Web Inspector: Remove directory tree from FileSystemView and add item-based navigation.
Product: WebKit Reporter: Taiju Tsuiki <tzik>
Component: Web Inspector (Deprecated)Assignee: Taiju Tsuiki <tzik>
Status: RESOLVED INVALID    
Severity: Normal CC: apavlov, burg, bweinstein, dglazkov, joepeck, keishi, loislo, pfeldman, pmuellr, rik, vsevik, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 68203, 91709    
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from gce-cr-linux-02
none
Patch
none
Patch
none
Rebase and test fix
vsevik: review-
Screenshot none

Description Taiju Tsuiki 2012-08-23 23:59:37 PDT
Per discussion on http://webkit.org/b/91709 ,
I'm removing directory tree from FileSystemView and adding navigation by double-clicking in main view.
Comment 1 Taiju Tsuiki 2012-08-24 00:20:58 PDT
Created attachment 160351 [details]
Patch
Comment 2 WebKit Review Bot 2012-08-24 04:06:21 PDT
Comment on attachment 160351 [details]
Patch

Attachment 160351 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13595121

New failing tests:
http/tests/inspector/filesystem/directory-tree.html
Comment 3 WebKit Review Bot 2012-08-24 04:06:24 PDT
Created attachment 160389 [details]
Archive of layout-test-results from gce-cr-linux-02

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-02  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Comment 4 Taiju Tsuiki 2012-09-04 22:17:30 PDT
Created attachment 162158 [details]
Patch
Comment 5 Taiju Tsuiki 2012-09-06 03:46:04 PDT
Created attachment 162469 [details]
Patch
Comment 6 WebKit Review Bot 2012-09-06 23:41:30 PDT
Comment on attachment 162469 [details]
Patch

Attachment 162469 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13774611

New failing tests:
http/tests/inspector/filesystem/ui/directory-content-view.html
Comment 7 Vsevolod Vlasov 2012-09-07 12:09:49 PDT
Comment on attachment 162469 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=162469&action=review

> Source/WebCore/inspector/front-end/FileSystemView.js:48
> +    this._navigateUpButton = new WebInspector.StatusBarButton(WebInspector.UIString("Go up to parent directory"), "navigate-up-status-bar-item");

This one was not present on the mocks and I don't really like it. We already have crumbs for this right there, we should probably add a ".." directory to the list instead.
Could you please provide a screenshot and some motivation?
Comment 8 Taiju Tsuiki 2012-09-10 08:14:23 PDT
Created attachment 163133 [details]
Rebase and test fix
Comment 9 Taiju Tsuiki 2012-09-10 08:19:10 PDT
Created attachment 163136 [details]
Screenshot
Comment 10 Taiju Tsuiki 2012-09-10 08:41:51 PDT
(In reply to comment #7)
> (From update of attachment 162469 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=162469&action=review
> 
> > Source/WebCore/inspector/front-end/FileSystemView.js:48
> > +    this._navigateUpButton = new WebInspector.StatusBarButton(WebInspector.UIString("Go up to parent directory"), "navigate-up-status-bar-item");
> 
> This one was not present on the mocks and I don't really like it. We already have crumbs for this right there, we should probably add a ".." directory to the list instead.
> Could you please provide a screenshot and some motivation?

Yes, this is not on mock.
Actually, I've not put crumbs in this patch, will put in next one.
As the motivation for adding "up to parent directory" button, there's no way to close opened file or directory, so I think we need a button to go to parent director until the crumb UI lands.

".." directory seems to work for going to parent directory from a directory, but we still need a button for closing file.
Comment 11 Vsevolod Vlasov 2012-09-14 03:13:10 PDT
> As the motivation for adding "up to parent directory" button, there's no way to close opened file or directory, so I think we need a button to go to parent director until the crumb UI lands.
This button looks ugly.
Instead of making it look prettier I suggest landing crumbs first.

> 
> ".." directory seems to work for going to parent directory from a directory, but we still need a button for closing file.
We can still use bread crumbs for that, aren't we?
Comment 12 Brian Burg 2014-08-03 18:30:40 PDT
This feature is no longer in WebKit.