Bug 94904

Summary: Web Inspector: move ResourceViews to "components" module - it is used from the Resources as well.
Product: WebKit Reporter: Pavel Feldman <pfeldman>
Component: Web Inspector (Deprecated)Assignee: Pavel Feldman <pfeldman>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, ossy, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 94911    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Pavel Feldman
Reported 2012-08-23 23:15:16 PDT
Patch to follow.
Attachments
Patch (5.75 KB, patch)
2012-08-23 23:22 PDT, Pavel Feldman 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2012-08-23 23:22:06 PDT
Created attachment 160339 [details] Patch
Pavel Feldman
Comment 2 2012-08-23 23:26:21 PDT
Committed r126546: <http://trac.webkit.org/changeset/126546>
WebKit Review Bot
Comment 3 2012-08-24 00:52:14 PDT
Re-opened since this is blocked by 94911
Csaba Osztrogonác
Comment 4 2012-08-24 01:22:00 PDT
(In reply to comment #3) > Re-opened since this is blocked by 94911 It was rolled out by http://trac.webkit.org/changeset/126546 . Additionally it broke 2 tests on Qt and on Mac: --- /Volumes/Data/slave/lion-debug-tests-wk1/build/layout-test-results/http/tests/inspector/network/network-sidebar-width-expected.txt +++ /Volumes/Data/slave/lion-debug-tests-wk1/build/layout-test-results/http/tests/inspector/network/network-sidebar-width-actual.txt @@ -4,4 +4,5 @@ Bug 65256 Sidebar width: 200 Sidebar width: 242 +Uncaught exception in inspector front-end: TypeError: 'undefined' is not a function (evaluating 'this.canEditSource()') [file:///Volumes/Data/slave/lion-debug-tests-wk1/build/WebKitBuild/Debug/WebCore.framework/Resources/inspector/SourceFrame.js:59] http/tests/inspector/resource-tree/resource-tree-reload.html: +Uncaught exception in inspector front-end: TypeError: 'undefined' is not a function [qrc:/webkit/inspector/SourceFrame.js:59]
Pavel Feldman
Comment 5 2012-08-24 02:23:12 PDT
Committed r126563: <http://trac.webkit.org/changeset/126563>
Note You need to log in before you can comment on or make changes to this bug.