Bug 94897

Summary: Don't use malloc / destructors for activation objects
Product: WebKit Reporter: Geoffrey Garen <ggaren>
Component: New BugsAssignee: Geoffrey Garen <ggaren>
Status: RESOLVED FIXED    
Severity: Normal CC: gustavo, philn, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch oliver: review+, webkit-ews: commit-queue-

Geoffrey Garen
Reported 2012-08-23 22:06:58 PDT
Don't use malloc / destructors for activation objects
Attachments
Patch (59.11 KB, patch)
2012-08-24 23:12 PDT, Geoffrey Garen 		oliver: review+
webkit-ews: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Geoffrey Garen
Comment 1 2012-08-24 23:12:26 PDT
Created attachment 160554 [details] Patch
Oliver Hunt
Comment 2 2012-08-24 23:31:23 PDT
Comment on attachment 160554 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=160554&action=review r+ if you can answer/correct the commented code > Source/JavaScriptCore/runtime/JSStaticScopeObject.cpp:45 > - visitor.append(&thisObject->m_registerStore); > + if (thisObject->m_registerStore) > + visitor.append(&thisObject->m_registerStore); you don't need this change > Source/JavaScriptCore/runtime/JSSymbolTableObject.cpp:45 > + JSNonFinalObject::visitChildren(thisObject, visitor); Should be Base::visitChildren unless you have a compelling reason not to > Source/JavaScriptCore/runtime/JSSymbolTableObject.cpp:46 > + if (thisObject->m_symbolTable) null check is unnecessary here > Source/JavaScriptCore/runtime/SymbolTable.cpp:47 > + SharedSymbolTable* thisObject = static_cast<SharedSymbolTable*>(cell); jsCast<>
Early Warning System Bot
Comment 3 2012-08-24 23:35:20 PDT
Comment on attachment 160554 [details] Patch Attachment 160554 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/13591517
Early Warning System Bot
Comment 4 2012-08-24 23:37:15 PDT
Comment on attachment 160554 [details] Patch Attachment 160554 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/13600387
Gyuyoung Kim
Comment 5 2012-08-24 23:37:17 PDT
Comment on attachment 160554 [details] Patch Attachment 160554 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/13604347
Build Bot
Comment 6 2012-08-25 07:37:59 PDT
Comment on attachment 160554 [details] Patch Attachment 160554 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/13601446
Geoffrey Garen
Comment 7 2012-08-25 20:24:59 PDT
Committed r126695: <http://trac.webkit.org/changeset/126695>
Note You need to log in before you can comment on or make changes to this bug.