Bug 94890

Summary: REGRESSION(r126132): thumb doesn't match click position for rtl input type=range
Product: WebKit Reporter: Keishi Hattori <keishi>
Component: FormsAssignee: Keishi Hattori <keishi>
Status: RESOLVED FIXED    
Severity: Normal CC: mifenton, tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Keishi Hattori
Reported 2012-08-23 19:27:53 PDT
r126132 broke it
Attachments
Patch (5.76 KB, patch)
2012-08-23 20:48 PDT, Keishi Hattori 		no flags
DetailsFormatted DiffDiff
Patch (7.51 KB, patch)
2012-08-23 21:04 PDT, Keishi Hattori 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Keishi Hattori
Comment 1 2012-08-23 20:48:04 PDT
Created attachment 160314 [details] Patch
Kent Tamura
Comment 2 2012-08-23 20:55:28 PDT
Comment on attachment 160314 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=160314&action=review > Source/WebCore/ChangeLog:3 > + thumb doesn't match click position for rtl input type=range Please follow our notation for a regression bug. REGRESSION(revision): description > Source/WebCore/html/shadow/SliderThumbElement.cpp:279 > + if (!renderBox()->style()->isLeftToRightDirection()) "renderBox()->style()->isLeftToRightDirection()" appears three times in this function. We had better holding it in a local variable.
Keishi Hattori
Comment 3 2012-08-23 21:04:53 PDT
Created attachment 160320 [details] Patch
Kent Tamura
Comment 4 2012-08-23 21:09:43 PDT
Comment on attachment 160320 [details] Patch ok
WebKit Review Bot
Comment 5 2012-08-23 21:55:15 PDT
Comment on attachment 160320 [details] Patch Clearing flags on attachment: 160320 Committed r126539: <http://trac.webkit.org/changeset/126539>
WebKit Review Bot
Comment 6 2012-08-23 21:55:18 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.