Bug 94879

Summary: Unify Number to StringImpl conversion
Product: WebKit Reporter: Benjamin Poulain <benjamin>
Component: Web Template FrameworkAssignee: Benjamin Poulain <benjamin>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch ggaren: review+

Benjamin Poulain
Reported 2012-08-23 17:16:49 PDT
Unify WTF::String::number() and UString::number() under one implementation.
Attachments
Patch (38.37 KB, patch)
2012-08-23 17:43 PDT, Benjamin Poulain 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2012-08-23 17:43:22 PDT
Created attachment 160295 [details] Patch
Geoffrey Garen
Comment 2 2012-08-24 16:20:23 PDT
Comment on attachment 160295 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=160295&action=review r=me > Source/WTF/wtf/text/IntegerToStringConversion.cpp:51 > + typename UnsignedIntegerTrait<SignedIntegerType>::Type workInteger; To be more specific, let's call "workInteger" "unsignedInteger" instead.
Benjamin Poulain
Comment 3 2012-08-24 17:12:58 PDT
Committed r126658: <http://trac.webkit.org/changeset/126658>
Note You need to log in before you can comment on or make changes to this bug.