Bug 94879

Summary: Unify Number to StringImpl conversion
Product: WebKit Reporter: Benjamin Poulain <benjamin>
Component: Web Template FrameworkAssignee: Benjamin Poulain <benjamin>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch ggaren: review+

Description Benjamin Poulain 2012-08-23 17:16:49 PDT
Unify WTF::String::number() and UString::number() under one implementation.
Comment 1 Benjamin Poulain 2012-08-23 17:43:22 PDT
Created attachment 160295 [details]
Patch
Comment 2 Geoffrey Garen 2012-08-24 16:20:23 PDT
Comment on attachment 160295 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=160295&action=review

r=me

> Source/WTF/wtf/text/IntegerToStringConversion.cpp:51
> +    typename UnsignedIntegerTrait<SignedIntegerType>::Type workInteger;

To be more specific, let's call "workInteger" "unsignedInteger" instead.
Comment 3 Benjamin Poulain 2012-08-24 17:12:58 PDT
Committed r126658: <http://trac.webkit.org/changeset/126658>