Bug 94834

Summary: [BlackBerry] Unify slow and fast in-region scrolling code paths
Product: WebKit Reporter: Antonio Gomes <tonikitoo>
Component: WebKit BlackBerryAssignee: Antonio Gomes <tonikitoo>
Status: RESOLVED FIXED    
Severity: Normal CC: mifenton, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 94839    
Attachments:
Description Flags
patch
rwlbuis: review-
patch - addressed rob's comments rwlbuis: review+

Antonio Gomes
Reported 2012-08-23 12:40:33 PDT
PR #197662
Attachments
patch (10.81 KB, patch)
2012-08-23 13:02 PDT, Antonio Gomes 		rwlbuis: review-
DetailsFormatted DiffDiff
patch - addressed rob's comments (10.97 KB, patch)
2012-08-23 13:25 PDT, Antonio Gomes 		rwlbuis: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Antonio Gomes
Comment 1 2012-08-23 13:02:52 PDT
Created attachment 160221 [details] patch
Rob Buis
Comment 2 2012-08-23 13:21:25 PDT
Comment on attachment 160221 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=160221&action=review Looks good, can be improved a bit. > Source/WebKit/blackberry/WebKitSupport/InRegionScrollableArea.cpp:108 > + ASSERT(!m_cachedCompositedScrollableLayer || !m_cachedNonCompositedScrollableNode); Please make the assert more clear, this is not strict enough for what you want. > Source/WebKit/blackberry/WebKitSupport/InRegionScrollableArea.cpp:141 > +} Better put this up instead of the forward declaration.
Antonio Gomes
Comment 3 2012-08-23 13:25:39 PDT
Created attachment 160230 [details] patch - addressed rob's comments
Rob Buis
Comment 4 2012-08-23 13:28:27 PDT
Comment on attachment 160230 [details] patch - addressed rob's comments LGTM.
Antonio Gomes
Comment 5 2012-08-23 13:44:34 PDT
https://trac.webkit.org/changeset/126474
Note You need to log in before you can comment on or make changes to this bug.