Bug 94826

Summary: Web Inspector: dblclick on Timeline overview no longer selects entire timeline range
Product: WebKit Reporter: Andrey Kosyakov <caseq>
Component: Web Inspector (Deprecated)Assignee: Andrey Kosyakov <caseq>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch vsevik: review+

Andrey Kosyakov
Reported 2012-08-23 10:13:15 PDT
0. Open WebInspector, switch to Timeline 1. Record a timeline 2. Double click on overview pane EXPECTED: Overview selection window is set to entire timeline range ACTUAL: A minimal interval is selected, as would be upon a single click This was apparently regressed by r123313
Attachments
Patch (3.44 KB, patch)
2012-08-23 10:15 PDT, Andrey Kosyakov 		vsevik: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andrey Kosyakov
Comment 1 2012-08-23 10:15:32 PDT
Created attachment 160191 [details] Patch
Vsevolod Vlasov
Comment 2 2012-08-23 10:30:21 PDT
Comment on attachment 160191 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=160191&action=review > Source/WebCore/inspector/front-end/UIUtils.js:69 > + function onMouseOut() WebInspector._mouseOutWhileDragging = function()... ? > Source/WebCore/inspector/front-end/UIUtils.js:71 > + targetDocument.removeEventListener("mouseout", onMouseOut, true); I would extract removeEventListener and delete statement.
Andrey Kosyakov
Comment 3 2012-08-23 10:45:47 PDT
Committed r126445: <http://trac.webkit.org/changeset/126445>
Note You need to log in before you can comment on or make changes to this bug.