Summary: | REGRESSION(r126306): it broke the plugin process | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> | ||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | gustavo, mrobinson, pnormand, webkit.review.bot, xan.lopez | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | Linux | ||||||
Attachments: |
|
Description
Carlos Garcia Campos
2012-08-23 04:54:31 PDT
Created attachment 160131 [details] Rollout r126306 Ok, I manually rolled out the webcore split, because other changes were added to the makefiles and automatic rollout wouldn't apply. I propose to roll this out for now to be able to finish the release and fix the problems afterwards. Btw, the make distcheck error I got was very similar (if not the same) to the one we had when supplemental idl stuff was added: CXX Source/WebCore/platform/graphics/libWebCorePlatform_la-Pattern.lo In file included from ../Source/WebCore/bindings/js/ScriptController.h:26:0, from ../Source/WebCore/page/Frame.h:40, from ../Source/WebCore/platform/graphics/MediaPlayer.cpp:33: ../Source/WebCore/bindings/js/JSDOMWindowShell.h:32:25: error fatal: JSDOMWindow.h: No existe el archivo o el directorio compilaciĆ³n terminada. I'm asking for review because I did the rollout manually, so I wanted to make sure ews was green and someone else had looked at the patch before landing it, just to be extra sure. Comment on attachment 160131 [details] Rollout r126306 Looks OK to me. Comment on attachment 160131 [details] Rollout r126306 Clearing flags on attachment: 160131 Committed r126421: <http://trac.webkit.org/changeset/126421> All reviewed patches have been landed. Closing bug. I'm trying kov's patch. It works fine with a debug build (flash works in minibrowser). Trying a release build now Release build works too... |