Bug 94797

Summary: REGRESSION(r126306): it broke the plugin process
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Severity: Normal CC: gustavo, mrobinson, pnormand, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Description Flags
Rollout r126306 none

Description Carlos Garcia Campos 2012-08-23 04:54:31 PDT
http://trac.webkit.org/changeset/126306 broke plugins in WebKit2:


All plugins fail to load due to a runtime symbol lookup error in the plugin process. It can be easily reproduced:

$ ../Tools/gtk/run-with-jhbuild Release/Programs/WebKitPluginProcess -scanplugin Release/TestNetscapePlugin/.libs/libtestnetscapeplugin.so
/home/cgarcia/WebKit/WebKitBuild/Release/Programs/.libs/lt-WebKitPluginProcess: symbol lookup error: /home/cgarcia/WebKit/WebKitBuild/Release/Programs/.libs/lt-WebKitPluginProcess: undefined symbol: _ZN7WebCore21WebKitFontFamilyNames14standardFamilyE

I think it also broke make distcheck.
Comment 1 Carlos Garcia Campos 2012-08-23 05:01:43 PDT
Created attachment 160131 [details]
Rollout r126306

Ok, I manually rolled out the webcore split, because other changes were added to the makefiles and automatic rollout wouldn't apply. I propose to roll this out for now to be able to finish the release and fix the problems afterwards.
Comment 2 Carlos Garcia Campos 2012-08-23 05:03:26 PDT
Btw, the make distcheck error I got was very similar (if not the same) to the one we had when supplemental idl stuff was added:

  CXX    Source/WebCore/platform/graphics/libWebCorePlatform_la-Pattern.lo
In file included from ../Source/WebCore/bindings/js/ScriptController.h:26:0,
                 from ../Source/WebCore/page/Frame.h:40,
                 from ../Source/WebCore/platform/graphics/MediaPlayer.cpp:33:
../Source/WebCore/bindings/js/JSDOMWindowShell.h:32:25: error fatal: JSDOMWindow.h: No existe el archivo o el directorio
compilaciĆ³n terminada.
Comment 3 Carlos Garcia Campos 2012-08-23 05:33:16 PDT
I'm asking for review because I did the rollout manually, so I wanted to make sure ews was green and someone else had looked at the patch before landing it, just to be extra sure.
Comment 4 Xan Lopez 2012-08-23 05:36:45 PDT
Comment on attachment 160131 [details]
Rollout r126306

Looks OK to me.
Comment 5 WebKit Review Bot 2012-08-23 06:21:18 PDT
Comment on attachment 160131 [details]
Rollout r126306

Clearing flags on attachment: 160131

Committed r126421: <http://trac.webkit.org/changeset/126421>
Comment 6 WebKit Review Bot 2012-08-23 06:21:21 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Philippe Normand 2012-11-13 11:09:50 PST
I'm trying kov's patch. It works fine with a debug build (flash works in minibrowser). Trying a release build now
Comment 8 Philippe Normand 2012-11-13 11:29:34 PST
Release build works too...