Bug 94784

Summary: [V8] ScheduledAction is ugly and needs a cleanup
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, eric, haraken, japhet, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
eric: review+, abarth: commit-queue+
Archive of layout-test-results from gce-cr-linux-07 none

Adam Barth
Reported 2012-08-23 00:18:51 PDT
[V8] ScheduledAction is ugly and needs a cleanup
Attachments
Patch (8.65 KB, patch)
2012-08-23 00:19 PDT, Adam Barth 		eric: review+
abarth: commit-queue+
DetailsFormatted DiffDiff
Archive of layout-test-results from gce-cr-linux-07 (376.91 KB, application/zip)
2012-08-23 01:05 PDT, WebKit Review Bot 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2012-08-23 00:19:49 PDT
Created attachment 160099 [details] Patch
Eric Seidel (no email)
Comment 2 2012-08-23 00:30:22 PDT
Comment on attachment 160099 [details] Patch Looks OK. You should wait for the cq/ews of course.
WebKit Review Bot
Comment 3 2012-08-23 01:05:24 PDT
Comment on attachment 160099 [details] Patch Attachment 160099 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13560600 New failing tests: http/tests/cache/post-with-cached-subresources.php
WebKit Review Bot
Comment 4 2012-08-23 01:05:27 PDT
Created attachment 160107 [details] Archive of layout-test-results from gce-cr-linux-07 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: gce-cr-linux-07 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Adam Barth
Comment 5 2012-08-23 10:50:53 PDT
Committed r126446: <http://trac.webkit.org/changeset/126446>
Note You need to log in before you can comment on or make changes to this bug.