Bug 94757

Summary: IndexedDB: Move onSuccess(IDBDatabaseBackendInterface) to IDBOpenDBRequest
Product: WebKit Reporter: Joshua Bell <jsbell>
Component: New BugsAssignee: Joshua Bell <jsbell>
Status: RESOLVED FIXED    
Severity: Normal CC: alecflett, dglazkov, dgrogan, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Joshua Bell
Reported 2012-08-22 16:38:05 PDT
IndexedDB: Move onSuccess(IDBDatabaseBackendInterface) to IDBOpenDBRequest
Attachments
Patch (8.57 KB, patch)
2012-08-22 16:39 PDT, Joshua Bell 		no flags
DetailsFormatted DiffDiff
Patch (10.27 KB, patch)
2012-08-22 17:24 PDT, Joshua Bell 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Joshua Bell
Comment 1 2012-08-22 16:39:22 PDT
Created attachment 160033 [details] Patch
Joshua Bell
Comment 2 2012-08-22 16:43:31 PDT
We discussed doing this in one of the upgradeneeded bugs but I can't find it at the moment. I think we thought it was a good idea - helps split up IDBRequest a bit, at any rate. dgrogan@, please take a look.
David Grogan
Comment 3 2012-08-22 16:49:15 PDT
Comment on attachment 160033 [details] Patch LGTM Yes, I remember talking about this.
WebKit Review Bot
Comment 4 2012-08-22 16:58:45 PDT
Comment on attachment 160033 [details] Patch Attachment 160033 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13571413
Joshua Bell
Comment 5 2012-08-22 17:24:20 PDT
Created attachment 160043 [details] Patch
Joshua Bell
Comment 6 2012-08-23 10:17:18 PDT
Failure was a test case exercising a now-removed method from IDBRequest. Patch updated. tony@ - r?
WebKit Review Bot
Comment 7 2012-08-23 11:56:07 PDT
Comment on attachment 160043 [details] Patch Clearing flags on attachment: 160043 Committed r126461: <http://trac.webkit.org/changeset/126461>
WebKit Review Bot
Comment 8 2012-08-23 11:56:10 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.