Bug 94754

Summary:

RenderMarquee should be a RenderBlock

Product:

WebKit

Reporter:

Julien Chaffraix <jchaffraix>

Component:

Layout and Rendering

Assignee:

Nobody <webkit-unassigned>

Status:

NEW ---

Severity:

Normal

CC:

ahmad.saleem792, ap, bfulgham, eae, eric, hyatt, inferno, leviw, simon.fraser, zalan

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Prototype patch: not for review as it doesn't have proper test coverage	none
Updated concept patch: manually tested to work	none

Description Julien Chaffraix 2012-08-22 15:46:28 PDT

Currently RenderMarquee is not a RenderObject and hangs off RenderLayer. It should be the other way around ie it's a RenderObject with a RenderLayer (or maybe even without one).

The most delicate part of this change is that we have very little coverage for RenderMarquee and the existing testing is very timing dependant (same issue as animation). We would need to increase the coverage before landing such a refactoring.

Comment 1 Julien Chaffraix 2012-08-22 15:47:56 PDT

Created attachment 160025 [details]
Prototype patch: not for review as it doesn't have proper test coverage

Comment 2 Julien Chaffraix 2013-01-25 18:30:27 PST

Created attachment 184850 [details]
Updated concept patch: manually tested to work

Comment 3 Ahmad Saleem 2022-09-12 04:29:56 PDT

Simon & Alan - Is this needed anymore? or it is "RESOLVED LATER"? Thanks!