Bug 94747

Summary: Test cases under fast/filesystem/workers are flaky when using JSC
Product: WebKit Reporter: Leo Yang <leo.yang>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, levin, staikos, tonikitoo, webkit.review.bot, yong.li.webkit
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch v2 none

Leo Yang
Reported 2012-08-22 13:56:57 PDT
These test cases sometimes can't complete because the worker object created by startWorker() has been gc'ed before the worker thread complete. We should reference the worker object returned by startWorker() to avoid being gc'ed. Patch is coming.
Attachments
Patch (12.61 KB, patch)
2012-08-22 14:14 PDT, Leo Yang 		no flags
DetailsFormatted DiffDiff
Patch v2 (13.37 KB, patch)
2012-08-22 14:23 PDT, Leo Yang 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Leo Yang
Comment 1 2012-08-22 14:14:07 PDT
Created attachment 160009 [details] Patch
Leo Yang
Comment 2 2012-08-22 14:17:24 PDT
Comment on attachment 160009 [details] Patch Hold on. There are more cases need to be updated.
Leo Yang
Comment 3 2012-08-22 14:23:02 PDT
Created attachment 160011 [details] Patch v2
Yong Li
Comment 4 2012-08-22 14:28:02 PDT
Comment on attachment 160011 [details] Patch v2 LGTM
WebKit Review Bot
Comment 5 2012-08-22 15:22:50 PDT
Comment on attachment 160011 [details] Patch v2 Clearing flags on attachment: 160011 Committed r126358: <http://trac.webkit.org/changeset/126358>
WebKit Review Bot
Comment 6 2012-08-22 15:22:53 PDT
All reviewed patches have been landed. Closing bug.
Alexey Proskuryakov
Comment 7 2012-08-23 09:58:51 PDT
> These test cases sometimes can't complete because the worker object > created by startWorker() has been gc'ed before the worker thread complete. Is this correct behavior, or a bug in JSC bindings?
Note You need to log in before you can comment on or make changes to this bug.