Bug 94747

Summary: Test cases under fast/filesystem/workers are flaky when using JSC
Product: WebKit Reporter: Leo Yang <leo.yang>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, levin, staikos, tonikitoo, webkit.review.bot, yong.li.webkit
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch v2 none

Description Leo Yang 2012-08-22 13:56:57 PDT
These test cases sometimes can't complete because the worker object created by startWorker() has been gc'ed before the worker thread complete. We should reference the worker object returned by startWorker() to avoid being gc'ed.

Patch is coming.
Comment 1 Leo Yang 2012-08-22 14:14:07 PDT
Created attachment 160009 [details]
Patch
Comment 2 Leo Yang 2012-08-22 14:17:24 PDT
Comment on attachment 160009 [details]
Patch

Hold on. There are more cases need to be updated.
Comment 3 Leo Yang 2012-08-22 14:23:02 PDT
Created attachment 160011 [details]
Patch v2
Comment 4 Yong Li 2012-08-22 14:28:02 PDT
Comment on attachment 160011 [details]
Patch v2

LGTM
Comment 5 WebKit Review Bot 2012-08-22 15:22:50 PDT
Comment on attachment 160011 [details]
Patch v2

Clearing flags on attachment: 160011

Committed r126358: <http://trac.webkit.org/changeset/126358>
Comment 6 WebKit Review Bot 2012-08-22 15:22:53 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Alexey Proskuryakov 2012-08-23 09:58:51 PDT
>        These test cases sometimes can't complete because the worker object
>        created by startWorker() has been gc'ed before the worker thread complete.

Is this correct behavior, or a bug in JSC bindings?