Bug 94744

Summary: [EFL][GTK] Use WTF_USE_SOUP instead BUILDING_SOUP__
Product: WebKit Reporter: Jesus Sanchez-Palencia <jesus>
Component: WebKit EFLAssignee: Jesus Sanchez-Palencia <jesus>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, gustavo, gyuyoung.kim, lucas.de.marchi, mrobinson, rakuco, tonikitoo, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch gustavo: review+

Description Jesus Sanchez-Palencia 2012-08-22 13:22:23 PDT 
There is still one usage of #if defined(BUILDING_SOUP__) in WebKit2/Shared/API/c/WKBase.h and currently this only defined by the efl port in cmake/OptionsEfl.cmake . I believe #if USE(SOUP) could be used instead.
Comment 1 Jesus Sanchez-Palencia 2012-08-22 13:29:21 PDT 
Created attachment 160001 [details]
Patch
Comment 2 Build Bot 2012-08-22 14:02:25 PDT 
Comment on attachment 160001 [details]
Patch

Attachment 160001 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/13573004
Comment 3 Early Warning System Bot 2012-08-22 14:08:19 PDT 
Comment on attachment 160001 [details]
Patch

Attachment 160001 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/13559432
Comment 4 Martin Robinson 2012-08-22 14:15:39 PDT 
Is WebKit2/Shared/API/c/WKBase.h is a public header? If so we probably shouldn't use WTF macros there.
Comment 5 Gyuyoung Kim 2012-08-22 14:19:13 PDT 
Comment on attachment 160001 [details]
Patch

Attachment 160001 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/13569376
Comment 6 Build Bot 2012-08-22 14:59:20 PDT 
Comment on attachment 160001 [details]
Patch

Attachment 160001 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/13567394
Comment 7 Gustavo Noronha (kov) 2012-08-22 16:46:59 PDT 
Comment on attachment 160001 [details]
Patch

Attachment 160001 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/13565473
Comment 8 Jesus Sanchez-Palencia 2012-08-23 07:57:05 PDT 
(In reply to comment #4)
> Is WebKit2/Shared/API/c/WKBase.h is a public header? If so we probably shouldn't use WTF macros there.

Yep, you are right, we can't use the macros but we can use #if defined(WTF_USE_SOUP) I guess. I've tested it locally and it worked with efl, I'm trying Qt and Gtk now.
Comment 9 Jesus Sanchez-Palencia 2012-08-23 08:27:52 PDT 
Created attachment 160169 [details]
Patch
Comment 10 Gustavo Noronha (kov) 2012-08-23 11:06:21 PDT 
Comment on attachment 160169 [details]
Patch

This looks no worse than what we already have, go ahead =)
Comment 11 Jesus Sanchez-Palencia 2012-08-23 11:28:28 PDT 
Committed r126453: <http://trac.webkit.org/changeset/126453>