Summary: | [BlackBerry] Add a check to filter out cookies that tries to set the domain to a top level domain | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | otcheung | ||||||||||
Component: | WebKit BlackBerry | Assignee: | Nobody <webkit-unassigned> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | mifenton, tonikitoo, webkit.review.bot | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
otcheung
2012-08-22 10:00:05 PDT
Created attachment 159958 [details]
Patch
Comment on attachment 159958 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=159958&action=review Looks good, needs some cleanup still. > Source/WebCore/ChangeLog:2 > + Remove one empty line here. > Source/WebCore/ChangeLog:11 > + If it is, throw it out when parsing Lacks a period at the end. > Source/WebCore/ChangeLog:18 > + and launcher commit. This seems not relevant here. I think it is better when adding the unit test to refer to this bug. Created attachment 159959 [details]
Patch
Comment on attachment 159959 [details]
Patch
LGTM.
Comment on attachment 159959 [details] Patch Rejecting attachment 159959 [details] from commit-queue. New failing tests: http/tests/cache/post-with-cached-subresources.php Full output: http://queues.webkit.org/results/13558384 Created attachment 159977 [details]
Archive of layout-test-results from gce-cq-01
The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: gce-cq-01 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Comment on attachment 159959 [details] Patch Clearing flags on attachment: 159959 Committed r126336: <http://trac.webkit.org/changeset/126336> All reviewed patches have been landed. Closing bug. Reopening to attach new patch. Created attachment 160258 [details]
Patch
Comment on attachment 160258 [details]
Patch
Looks good.
Comment on attachment 160258 [details] Patch Clearing flags on attachment: 160258 Committed r126504: <http://trac.webkit.org/changeset/126504> All reviewed patches have been landed. Closing bug. |