Bug 94722

Summary:

[BlackBerry] Add a check to filter out cookies that tries to set the domain to a top level domain

Product:

WebKit

Reporter:

otcheung

Component:

WebKit BlackBerry

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

mifenton, tonikitoo, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Archive of layout-test-results from gce-cq-01	none
Patch	none

otcheung

Reported 2012-08-22 10:00:05 PDT

Adding country-code & normal TLD checks to prevent cookies from setting cookies to top level domains.

Attachments
Patch (2.51 KB, patch) 2012-08-22 10:10 PDT, otcheung	no flags	Details Formatted Diff Diff
Patch (2.39 KB, patch) 2012-08-22 10:30 PDT, otcheung	no flags	Details Formatted Diff Diff
Archive of layout-test-results from gce-cq-01 (570.59 KB, application/zip) 2012-08-22 11:25 PDT, WebKit Review Bot	no flags	Details
Patch (2.15 KB, patch) 2012-08-23 15:04 PDT, otcheung	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

otcheung

Comment 1 2012-08-22 10:10:21 PDT

Created attachment 159958 [details] Patch

Rob Buis

Comment 2 2012-08-22 10:23:47 PDT

Comment on attachment 159958 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=159958&action=review Looks good, needs some cleanup still. > Source/WebCore/ChangeLog:2 > + Remove one empty line here. > Source/WebCore/ChangeLog:11 > + If it is, throw it out when parsing Lacks a period at the end. > Source/WebCore/ChangeLog:18 > + and launcher commit. This seems not relevant here. I think it is better when adding the unit test to refer to this bug.

otcheung

Comment 3 2012-08-22 10:30:42 PDT

Created attachment 159959 [details] Patch

Rob Buis

Comment 4 2012-08-22 10:34:22 PDT

Comment on attachment 159959 [details] Patch LGTM.

WebKit Review Bot

Comment 5 2012-08-22 11:25:42 PDT

Comment on attachment 159959 [details] Patch Rejecting attachment 159959 [details] from commit-queue. New failing tests: http/tests/cache/post-with-cached-subresources.php Full output: http://queues.webkit.org/results/13558384

WebKit Review Bot

Comment 6 2012-08-22 11:25:44 PDT

Created attachment 159977 [details] Archive of layout-test-results from gce-cq-01 The attached test failures were seen while running run-webkit-tests on the commit-queue. Bot: gce-cq-01 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid

WebKit Review Bot

Comment 7 2012-08-22 12:36:31 PDT

Comment on attachment 159959 [details] Patch Clearing flags on attachment: 159959 Committed r126336: <http://trac.webkit.org/changeset/126336>

WebKit Review Bot

Comment 8 2012-08-22 12:36:34 PDT

All reviewed patches have been landed. Closing bug.

otcheung

Comment 9 2012-08-23 15:04:18 PDT

Reopening to attach new patch.

otcheung

Comment 10 2012-08-23 15:04:26 PDT

Created attachment 160258 [details] Patch

Rob Buis

Comment 11 2012-08-23 15:26:40 PDT

Comment on attachment 160258 [details] Patch Looks good.

WebKit Review Bot

Comment 12 2012-08-23 16:48:27 PDT

Comment on attachment 160258 [details] Patch Clearing flags on attachment: 160258 Committed r126504: <http://trac.webkit.org/changeset/126504>

WebKit Review Bot

Comment 13 2012-08-23 16:48:30 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.