Bug 94692

Summary: [Qt][WK2] Enable runtime enabled features: DeviceMotion and DeviceOrientation
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: New BugsAssignee: Csaba Osztrogonác <ossy>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, hausmann, kbalazs, menard, ossy, webkit.review.bot, zoltan
Priority: P2 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Csaba Osztrogonác
Reported 2012-08-22 04:50:02 PDT
After https://trac.webkit.org/changeset/126057/trunk/Source/WebCore/page/DOMWindow.cpp the following tests started to fail: (because DeviceMotion and DeviceOrientation runtime enabled features are disabled on Qt WK2 and it wasn't checked before.) - fast/dom/DeviceMotion/no-page-cache.html - fast/dom/DeviceOrientation/no-page-cache.html I tried to enable them and then these tests pass. Now there are 4-4 non-skipped DeviceMotion and DeviceOrientation tests on Qt-WK2 and all of them pass.
Attachments
Patch (1.48 KB, patch)
2012-08-22 05:27 PDT, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1 2012-08-22 05:27:03 PDT
Created attachment 159909 [details] Patch
Csaba Osztrogonác
Comment 2 2012-08-22 05:27:36 PDT
They were disabled by https://trac.webkit.org/changeset/73876 (two years before) because of crashes. But now they work fine.
Simon Hausmann
Comment 3 2012-08-22 06:06:21 PDT
Awesome, thanks Ossy! :)
WebKit Review Bot
Comment 4 2012-08-22 06:21:36 PDT
Comment on attachment 159909 [details] Patch Clearing flags on attachment: 159909 Committed r126296: <http://trac.webkit.org/changeset/126296>
WebKit Review Bot
Comment 5 2012-08-22 06:21:39 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.