Bug 94692

Summary: [Qt][WK2] Enable runtime enabled features: DeviceMotion and DeviceOrientation
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: New BugsAssignee: Csaba Osztrogonác <ossy>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, hausmann, kbalazs, menard, ossy, webkit.review.bot, zoltan
Priority: P2 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Description Csaba Osztrogonác 2012-08-22 04:50:02 PDT
After https://trac.webkit.org/changeset/126057/trunk/Source/WebCore/page/DOMWindow.cpp
the following tests started to fail: (because DeviceMotion and DeviceOrientation runtime
enabled features are disabled on Qt WK2 and it wasn't checked before.)
- fast/dom/DeviceMotion/no-page-cache.html
- fast/dom/DeviceOrientation/no-page-cache.html

I tried to enable them and then these tests pass. Now there are 4-4 non-skipped 
DeviceMotion and DeviceOrientation tests on Qt-WK2 and all of them pass.
Comment 1 Csaba Osztrogonác 2012-08-22 05:27:03 PDT
Created attachment 159909 [details]
Patch
Comment 2 Csaba Osztrogonác 2012-08-22 05:27:36 PDT
They were disabled by https://trac.webkit.org/changeset/73876 
(two years before) because of crashes. But now they work fine.
Comment 3 Simon Hausmann 2012-08-22 06:06:21 PDT
Awesome, thanks Ossy! :)
Comment 4 WebKit Review Bot 2012-08-22 06:21:36 PDT
Comment on attachment 159909 [details]
Patch

Clearing flags on attachment: 159909

Committed r126296: <http://trac.webkit.org/changeset/126296>
Comment 5 WebKit Review Bot 2012-08-22 06:21:39 PDT
All reviewed patches have been landed.  Closing bug.