Bug 94684

Summary: Get rid of m_useLatchedWheelEventNode
Product: WebKit Reporter: Allan Sandfeld Jensen <allan.jensen>
Component: UI EventsAssignee: Allan Sandfeld Jensen <allan.jensen>
Status: RESOLVED FIXED    
Severity: Minor CC: andersca, ap, bdakin, rjkroege, rniwa, timothy, webkit.review.bot
Priority: P2    
Version: 420+   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 94478    
Attachments:
Description Flags
Patch none

Allan Sandfeld Jensen
Reported 2012-08-22 02:43:28 PDT
EventHandler has a "global" flag called m_useLatchedWheelEventNode which is used only to tell if the currently handled wheel-event should use latched nodes. Since this is event specific, this flag would be better to have in PlatformWheelEvent.
Attachments
Patch (7.33 KB, patch)
2012-08-22 03:13 PDT, Allan Sandfeld Jensen 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Allan Sandfeld Jensen
Comment 1 2012-08-22 03:13:36 PDT
Created attachment 159892 [details] Patch
Eric Seidel (no email)
Comment 2 2012-08-22 13:27:26 PDT
Comment on attachment 159892 [details] Patch LGTM. Did you CC whoever added this originally? Do we have ways to test this?
Robert Kroeger
Comment 3 2012-08-22 13:38:46 PDT
fwiw: I like this change. regarding tests: it would be really if EventSender permitted setting the latched flag yes? That would make it possible to expand the existing layout tests in fast/event/touch/gesture to be enhanced to show that latched/non-latched mode are getting handled correctly.
Allan Sandfeld Jensen
Comment 4 2012-08-22 13:43:12 PDT
(In reply to comment #2) > (From update of attachment 159892 [details]) > LGTM. Did you CC whoever added this originally? Do we have ways to test this? Anders Carlson seems to have added it to EventHandler.cpp, and Timothy last touched it, I CC'ed both of them. There is no real change in functionality to test. It does appears to be tested indirectly by a number of tests, at least I had some tests breaking when I had a bug in an earlier version of the patch
Ryosuke Niwa
Comment 5 2012-08-23 23:31:31 PDT
Comment on attachment 159892 [details] Patch This looks right.
WebKit Review Bot
Comment 6 2012-08-24 01:40:32 PDT
Comment on attachment 159892 [details] Patch Clearing flags on attachment: 159892 Committed r126556: <http://trac.webkit.org/changeset/126556>
WebKit Review Bot
Comment 7 2012-08-24 01:40:35 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.