| Summary: | Get rid of m_useLatchedWheelEventNode | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Allan Sandfeld Jensen <allan.jensen> | ||||
| Component: | UI Events | Assignee: | Allan Sandfeld Jensen <allan.jensen> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Minor | CC: | andersca, ap, bdakin, rjkroege, rniwa, timothy, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 420+ | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 94478 | ||||||
| Attachments: |
|
||||||
|
Description
Allan Sandfeld Jensen
2012-08-22 02:43:28 PDT
Created attachment 159892 [details]
Patch
Comment on attachment 159892 [details]
Patch
LGTM. Did you CC whoever added this originally? Do we have ways to test this?
fwiw: I like this change. regarding tests: it would be really if EventSender permitted setting the latched flag yes? That would make it possible to expand the existing layout tests in fast/event/touch/gesture to be enhanced to show that latched/non-latched mode are getting handled correctly. (In reply to comment #2) > (From update of attachment 159892 [details]) > LGTM. Did you CC whoever added this originally? Do we have ways to test this? Anders Carlson seems to have added it to EventHandler.cpp, and Timothy last touched it, I CC'ed both of them. There is no real change in functionality to test. It does appears to be tested indirectly by a number of tests, at least I had some tests breaking when I had a bug in an earlier version of the patch Comment on attachment 159892 [details]
Patch
This looks right.
Comment on attachment 159892 [details] Patch Clearing flags on attachment: 159892 Committed r126556: <http://trac.webkit.org/changeset/126556> All reviewed patches have been landed. Closing bug. |