Summary: | [GTK] Preferred languages and spellchecker APIs are not consistent in WebKit2 | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> | ||||
Component: | WebKit2 | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | alex, gustavo, mario, mrobinson, pnormand, webkit.review.bot, xan.lopez | ||||
Priority: | P2 | Keywords: | Gtk | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | Linux | ||||||
Attachments: |
|
Description
Carlos Garcia Campos
2012-08-22 02:07:20 PDT
Created attachment 159886 [details]
Patch
This is an api break so it would be great to land it before the release.
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API As the author of the previous version of this API, I must say I agree with this change and that the current patch looks good to me too Comment on attachment 159886 [details]
Patch
LGTM!
Committed r126298: <http://trac.webkit.org/changeset/126298> |